feat(pr-validation)!: smoke test the breaking change approval gate by bedatty · Pull Request #906 · LerianStudio/github-actions-shared-workflows

bedatty · 2026-10-15T19:59:20Z

Description

Smoke test for the breaking-change approval gate shipped in #904. The commit is deliberately marked ! so the gate fires.

Not meant to be merged. It will be closed once the gate has been observed — or closed by the gate itself, if the breaking change is rejected.

What this exercises:

pr-gate-scope puts it in scope (anything into develop)
breaking-change-guard detects the ! subject
codeowners-reviewers derives team:g_github_devops from CODEOWNERS
environment-protection creates breaking-approval, which does not exist yet
The run holds at the pending deployment until somebody answers

Type of Change

test: Adding or updating tests

Breaking Changes

None — the ! is the test fixture. This PR is closed, never merged.

Testing

Checked that unrelated workflows are not affected

Related Issues

Breaking change acknowledged: I understand that this PR intentionally introduces a breaking change and requires the next release to be a major version.

Deliberately marked breaking so the gate fires. This pull request exists to watch it work end to end and is not meant to be merged.

coderabbitai · 2026-10-15T19:59:31Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: LerianStudio/github-actions-shared-workflows/.coderabbit.yml
Review profile: ASSERTIVE
Plan: Essentials
Run ID: 093bef2d-cb05-42fb-a237-1cf05ca1721b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

lerian-studio · 2026-10-15T19:59:57Z

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check	Status	Blocking
Source Branch	✅ success	yes
PR Title	✅ success	yes
PR Description	✅ success	yes
Breaking Change Guard	✅ success	yes
Commit Signatures	✅ success	yes
PR Size	✅ success	no
Auto Labels	✅ success	no
PR Metadata	✅ success	no

_{🔍 View workflow run}

lerian-studio · 2026-10-15T19:59:58Z

Caution

⛔ Breaking change rejected

Rejected by guimoreirar.

This pull request was closed. The branch is untouched — rework it without the break and reopen.

_{Gated by rule develop <- '*' · How this gate works}

lerian-studio · 2026-10-15T20:00:40Z

🔍 Lint Analysis

Check	Files Scanned	Status
YAML Lint	no changes	⏭️ skipped
Action Lint	no changes	⏭️ skipped
Pinned Actions	no changes	⏭️ skipped
Markdown Link Check	1 file(s)	✅ success
Spelling Check	1 file(s)	✅ success
Shell Check	no changes	⏭️ skipped
README Check	no changes	⏭️ skipped
Composite Schema	no changes	⏭️ skipped
Deployment Matrix	no changes	⏭️ skipped

_{🔍 View full scan logs}

Reported on #906: two bot comments about the same breaking change, one headed "Breaking change guard — ✅ Author acknowledged" and one asking for a decision. The ✅ reads as the approval. It is not: it says the author declared the break, and the small print saying so is small print. The second comment only appeared yesterday, when #913 fixed the 403 that had kept it silent since August. Fixing the permission put a ✅ next to a pending request without my noticing the two would collide. `breaking-change-comment` is removed. The gate's comment already carries the acknowledgement state, with the decision as the headline and the acknowledgement as a row — the hierarchy the two controls actually have. To replace what the removed comment covered, the gate now comments wherever a breaking change is found, not only inside its approval scope. Outside it there is no decision to make, so the comment reports the acknowledgement and the exact line to paste. The waiting comment carries that line too, folded away, since Blocking Checks fails on a missing acknowledgement whether or not an approval is pending. pr-validation now passes the acknowledgement literal to the gate instead of relying on the default to coincide. They were equal by hand across two files; a drift would have had the gate teaching a line that fails the check it was explaining.

lerian-studio · 2026-10-16T19:15:26Z

🛡️ CodeQL Analysis Results

Languages analyzed: actions

✅ No security issues found.

_{🔍 View full scan logs | 🛡️ Security tab}

CodeQL flagged `actions/untrusted-checkout` at the second checkout, and the alert was fair. The gate runs on `pull_request`, so it is not privileged — but it was still placing a contributor's tree on disk in a job that carries MANAGE_TOKEN. Nothing executed that tree, and nothing needed it: the only thing read from it was commit messages, which the API serves. The `breaking-change-commits` composite was already running here for the fingerprint, reading exactly those commits through the API with patterns kept identical to the detector. It now does the detecting too, when the caller has not detected already. Two checkouts, the Git-reading composite, the tree, the token exposure and the alert all go together. `breaking-change-guard` remains the canonical detector and still runs in pr-validation over the real commit range — which is the verdict this gate is handed in the path that matters. One consequence worth stating: on the standalone path the acknowledgement is no longer evaluated, because the detector that reads the description lives in pr-validation. The state is reported as unknown rather than missing, and the comment omits the row. Telling an author to add a line that no check is asking for is worse than saying nothing.

feat(pr-validation)!: smoke test the breaking change approval gate

f8d5506

Deliberately marked breaking so the gate fires. This pull request exists to watch it work end to end and is not meant to be merged.

bedatty requested a review from a team as a code owner October 15, 2026 19:59

lerian-studio added the breaking-change Callers must update their workflow configuration after this change label Oct 15, 2026

bedatty requested a deployment to breaking-approval October 15, 2026 20:00 — with GitHub Actions Waiting

bedatty mentioned this pull request Oct 15, 2026

fix(pr-validation): make the breaking-change comment read as information #907

Merged

5 of 14 tasks

Merge branch 'develop' into test/breaking-change-gate-smoke

229bdd0

bedatty requested a deployment to breaking-approval October 15, 2026 21:38 — with GitHub Actions Waiting

bedatty mentioned this pull request Oct 15, 2026

feat(pr-validation): button, real undo example, one live approval #908

Merged

5 of 6 tasks

Merge branch 'develop' into test/breaking-change-gate-smoke

4a33204

bedatty had a problem deploying to breaking-approval October 15, 2026 21:51 — with GitHub Actions Error

bedatty mentioned this pull request Oct 15, 2026

feat(pr-validation): mark the breaking change so it reads at a glance #909

Merged

5 of 6 tasks

test(pr-validation): probe whether a push cancels the pending approval

607848b

bedatty had a problem deploying to breaking-approval October 15, 2026 21:59 — with GitHub Actions Error

Merge branch 'develop' into test/breaking-change-gate-smoke

de70a29

bedatty had a problem deploying to breaking-approval October 16, 2026 00:46 — with GitHub Actions Error

Merge branch 'develop' into test/breaking-change-gate-smoke

ab25957

bedatty had a problem deploying to breaking-approval October 16, 2026 01:07 — with GitHub Actions Error

lerian-studio assigned bedatty Oct 16, 2026

lerian-studio added size/XS PR changes < 50 lines documentation Improvements or additions to documentation labels Oct 16, 2026

bedatty had a problem deploying to breaking-approval October 16, 2026 01:11 — with GitHub Actions Error

lerian-studio removed the breaking-change Callers must update their workflow configuration after this change label Oct 16, 2026

bedatty mentioned this pull request Oct 16, 2026

fix(pr-validation): treat a cancelled approval as superseded #912

Merged

6 of 14 tasks

Merge branch 'develop' into test/breaking-change-gate-smoke

be6218e

lerian-studio added the breaking-change Callers must update their workflow configuration after this change label Oct 16, 2026

bedatty had a problem deploying to breaking-approval October 16, 2026 12:26 — with GitHub Actions Error

lerian-studio added size/M PR changes 200–499 lines and removed size/XS PR changes < 50 lines labels Oct 16, 2026

bedatty had a problem deploying to breaking-approval October 16, 2026 19:15 — with GitHub Actions Error

lerian-studio added workflow Changes to one or more reusable workflow files notify Changes to notification composite actions (src/notify/) validate Changes to PR validation composite actions (src/validate/) composite Changes to any composite action manifest (src/**/*.yml) labels Oct 16, 2026

bedatty had a problem deploying to breaking-approval October 16, 2026 19:28 — with GitHub Actions Error

bedatty mentioned this pull request Oct 16, 2026

feat(pr-validation): one breaking-change comment, and no checkout #918

Merged

6 of 14 tasks

Merge branch 'develop' into test/breaking-change-gate-smoke

8c60373

bedatty had a problem deploying to breaking-approval October 16, 2026 20:14 — with GitHub Actions Error

Merge branch 'develop' into test/breaking-change-gate-smoke

5b8d64b

bedatty had a problem deploying to breaking-approval October 16, 2026 20:49 — with GitHub Actions Error

test(pr-validation): probe the two-label lifecycle on a live PR

ff8d64c

lerian-studio added the awaiting-breaking-approval A breaking change on this PR is waiting on a human decision label Oct 16, 2026

bedatty had a problem deploying to breaking-approval October 16, 2026 20:58 — with GitHub Actions Failure

bedatty mentioned this pull request Oct 16, 2026

test(pr-validation): fixture for the approval and reuse flow #920

Closed

5 of 6 tasks

guimoreirar approved these changes Oct 16, 2026

View reviewed changes

lerian-studio removed the awaiting-breaking-approval A breaking change on this PR is waiting on a human decision label Oct 16, 2026

lerian-studio closed this Oct 16, 2026

bedatty mentioned this pull request Oct 16, 2026

fix(pr-validation): do not re-ask when the approval already stands #921

Merged

6 of 14 tasks

Navigation Menu

Repository navigation

feat(pr-validation)!: smoke test the breaking change approval gate - #906

feat(pr-validation)!: smoke test the breaking change approval gate#906
bedatty wants to merge 13 commits into
developfrom
test/breaking-change-gate-smoke

bedatty commented Oct 15, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 15, 2026 •

edited

Loading

Review skipped

Uh oh!

lerian-studio commented Oct 15, 2026 •

edited

Loading

Uh oh!

lerian-studio commented Oct 15, 2026 •

edited

Loading

⛔ Breaking change rejected

Uh oh!

lerian-studio commented Oct 15, 2026 •

edited

Loading

Uh oh!

lerian-studio commented Oct 16, 2026 •

edited

Loading

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bedatty commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Breaking Changes

Testing

Related Issues

Uh oh!

coderabbitai Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

lerian-studio commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Uh oh!

lerian-studio commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⛔ Breaking change rejected

Uh oh!

lerian-studio commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Lint Analysis

Uh oh!

lerian-studio commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛡️ CodeQL Analysis Results

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bedatty commented Oct 15, 2026 •

edited

Loading

coderabbitai Bot commented Oct 15, 2026 •

edited

Loading

lerian-studio commented Oct 15, 2026 •

edited

Loading

lerian-studio commented Oct 15, 2026 •

edited

Loading

lerian-studio commented Oct 15, 2026 •

edited

Loading

lerian-studio commented Oct 16, 2026 •

edited

Loading