Skip to content

fix(ungoliant): bump curl-timeout default from 300s to 900s #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bedatty merged 3 commits into from
Jul 14, 2026
Merged

fix(ungoliant): bump curl-timeout default from 300s to 900s #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4298e1
fix(ungoliant): bump curl-timeout default from 300s to 900s
bedatty Jul 14, 2026
ccef62e
docs(ungoliant): document curl-timeout lockstep requirement in README
bedatty Jul 14, 2026
32d818e
Merge branch 'develop' into fix/ungoliant-release-diff-timeout
bedatty Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/validate/ungoliant-release-diff/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ This is the CI equivalent of `ungoliant-controller/docs/testing/cluster/test-rel
| `github-token` | GitHub token used to read tags, compare and diff via the API. | Yes | |
| `webhook-token` | Ungoliant webhook token sent as the `X-Ungoliant-Token` header. | No | `""` |
| `max-diff-bytes` | Maximum diff size forwarded to the controller (bytes). | No | `262144` |
| `curl-timeout` | Timeout for the webhook POST in seconds. | No | `300` |
| `curl-timeout` | Timeout for the webhook POST in seconds. Must stay in lockstep with `ungoliant-controller`'s `NEMOCLAW_TIMEOUT_SECONDS` and its ingress proxy timeouts — don't change this in isolation. | No | `900` |
| `dry-run` | Resolve and preview the payload without firing the webhook. | No | `false` |

## Outputs
Expand Down
4 changes: 2 additions & 2 deletions src/validate/ungoliant-release-diff/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ inputs:
required: false
default: "262144"
curl-timeout:
description: Timeout for the webhook POST in seconds (LLM inference can take 60-120s)
description: Timeout for the webhook POST in seconds (LLM inference can take 60-120s, longer for large/complex diffs). Must stay in lockstep with ungoliant-controller's NEMOCLAW_TIMEOUT_SECONDS and its ingress proxy timeouts.
required: false
default: "300"
default: "900"
Comment thread
bedatty marked this conversation as resolved.
dry-run:
description: Resolve and preview the payload without firing the webhook
required: false
Expand Down