Repository navigation
fix(ungoliant): bump curl-timeout default from 300s to 900s - #571
Merged
Merged
Conversation
midaz's release-diff timed out at exactly 300s (github.com/LerianStudio/midaz/actions/runs/29279206313) — its diff is large/complex enough that inference + schema validation exceeds the previous default. Bumped alongside ungoliant-controller's NEMOCLAW_TIMEOUT_SECONDS and its ingress proxy timeouts (both moved to 900/960s in lerian-internal-gitops), which this value must stay in lockstep with — a client-side timeout shorter than the controller's own budget fails the CI job even when the controller would have eventually succeeded.
Contributor
|
Pull requests to main can only come from:
Your source branch: Please change the base branch or create a PR from an allowed branch. |
WalkthroughThe Ungoliant release-diff action increases the ChangesUngoliant webhook timeout
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
Contributor
🔍 Lint Analysis
|
lerian-studio
added
size/XS
Contributor
🛡️ CodeQL Analysis ResultsLanguages analyzed: ✅ No security issues found. 🔍 View full scan logs | 🛡️ Security tab |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/validate/ungoliant-release-diff/action.yml`:
- Around line 50-53: The curl-timeout default in the action metadata changes the
caller-visible contract from 300 to 900 seconds. Either restore the default to
300, or update both release workflow callers to pass an explicit timeout so the
new 900-second behavior is intentional and documented at each call site.
In `@src/validate/ungoliant-release-diff/README.md`:
- Line 37: Update the README documentation for the curl-timeout input to state
that its value must remain synchronized with the controller and ingress proxy
timeouts, while preserving the documented 900-second default and keeping usage
and behavior notes consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 58cc7bb4-d28a-4cb1-a407-9534f4ef90a1
📒 Files selected for processing (2)
src/validate/ungoliant-release-diff/README.mdsrc/validate/ungoliant-release-diff/action.yml
action.yml's own input description already states this must stay aligned with ungoliant-controller's NEMOCLAW_TIMEOUT_SECONDS and its ingress proxy timeouts, but the README table only showed the bare number — a README-only reader could plausibly bump curl-timeout alone without knowing the other two must move with it. Addresses CodeRabbit review comment on PR #571.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions Shared Workflows
Description
Affects:
src/validate/ungoliant-release-diff(composite action used bygo-release.yml'sungoliant_release_diffjob).Bumps the
curl-timeoutinput's default from 300s to 900s.midaz's release-diff timed out at exactly 300s (run) — its diff is large/complex enough that inference + schema validation on the controller side exceeds the previous default.This must move in lockstep with two companion changes in
lerian-internal-gitops(ungoliant-controller'sNEMOCLAW_TIMEOUT_SECONDSenv var and its ingressproxy-read-timeout/proxy-send-timeoutannotations, both bumped to 900/960s) — a client-side timeout shorter than the controller's own budget fails the CI job even when the controller would have eventually succeeded.No caller repo sets
curl-timeoutexplicitly (confirmed viago-release.yml, which doesn't pass this input through), so every consumer picks up the new default automatically once this releases and the@v1tag moves.Type of Change
fix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)Breaking Changes
None — only a default value change; any caller can still override it explicitly.
Testing
python3 -c "import yaml; yaml.safe_load(...)")midaz's release-diff after this merges and releasesCaller repo / workflow run: https://github.com/LerianStudio/midaz/actions/runs/29279206313 (the failure this fixes)
Related Issues
Closes #