Skip to content

Restore requested dimensions when CPU snapshot graphics initializes - #14649

Closed
r-barton wants to merge 1 commit into
mainfrom
ryan/cpu-snapshot-dimensions
Closed

r-barton wants to merge 1 commit into
mainfrom
ryan/cpu-snapshot-dimensions

Conversation

@r-barton

Copy link
Copy Markdown
Contributor

CPU snapshots can ignore video_res_width and video_res_height: a session requesting 320×240 currently receives 1280×720 because older engines replace the connection dimensions while graphics is disabled.

After enabling CPU graphics, restore the requested canvas dimensions before applying graphics settings and camera framing. Repeat this whenever graphics is initialized, since native snapshots disable graphics again after capture. Omitted or zero axes use the existing engine defaults.

The rebuilt Python bindings returned the requested 320×240, 1024×1024, and 1600×900 images against the dev CPU engine. Each size was captured twice in the same session to exercise graphics teardown and restart.

Companion fixes:

Related CPU-only rollout: https://github.com/KittyCAD/text-to-cad/pull/4465.

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Oct 16, 2026 2:44pm UTC

Request Review

@codspeed

codspeed Bot commented Oct 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 157 untouched benchmarks
⏩ 131 skipped benchmarks1


Comparing ryan/cpu-snapshot-dimensions (ad52a2e) with main (830649d)

Open in CodSpeed

Footnotes

  1. 131 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@r-barton r-barton closed this Oct 16, 2026

This branch was successfully deployed

1 active deployment
Preview — ad52a2eb Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant