Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merging this PR will not alter performance
Comparing Footnotes
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPU snapshots can ignore
video_res_widthandvideo_res_height: a session requesting 320×240 currently receives 1280×720 because older engines replace the connection dimensions while graphics is disabled.After enabling CPU graphics, restore the requested canvas dimensions before applying graphics settings and camera framing. Repeat this whenever graphics is initialized, since native snapshots disable graphics again after capture. Omitted or zero axes use the existing engine defaults.
The rebuilt Python bindings returned the requested 320×240, 1024×1024, and 1600×900 images against the dev CPU engine. Each size was captured twice in the same session to exercise graphics teardown and restart.
Companion fixes:
Related CPU-only rollout: https://github.com/KittyCAD/text-to-cad/pull/4465.