Repository navigation
Include executed imported files in glTF exports - #14442
Draft
Joe-Spencer wants to merge 1 commit into
Draft
Joe-Spencer wants to merge 1 commit into
Joe-Spencer wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merging this PR will not alter performance
Comparing Footnotes
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain original foreign-import bytes and resolved paths with the successful execution snapshot, including external glTF buffers. glTF export forwards those executed inputs alongside KCL source, so cache hits and later file edits cannot pair exported geometry with newer file contents. Only executed imports are included; repeated identical paths deduplicate, while conflicting bytes and unrepresentable project paths produce an actionable glTF export error. Other export formats retain the existing KCL-source behavior.
Stacked on #14003. Depends on modeling-api #1442, format #925, and engine #5303. The API revision, Cargo lock entries, and Nix source hash are updated, and modeling-command bindings are regenerated.
Request-recording regressions cover exact non-UTF-8 bytes, nested buffer dependencies, unused assets, repeated imports, cached file changes, mock execution, failure/recovery, cross-drive paths, and unresolved traversal. A Studio import/export smoke test with the updated engine remains necessary before landing.