Skip to content

Include executed imported files in glTF exports - #14442

Draft
Joe-Spencer wants to merge 1 commit into
codex/export-kcl-sourcefrom
codex/gltf-imported-files
Draft

Joe-Spencer wants to merge 1 commit into
codex/export-kcl-sourcefrom
codex/gltf-imported-files

Conversation

@Joe-Spencer

Copy link
Copy Markdown
Contributor

Retain original foreign-import bytes and resolved paths with the successful execution snapshot, including external glTF buffers. glTF export forwards those executed inputs alongside KCL source, so cache hits and later file edits cannot pair exported geometry with newer file contents. Only executed imports are included; repeated identical paths deduplicate, while conflicting bytes and unrepresentable project paths produce an actionable glTF export error. Other export formats retain the existing KCL-source behavior.

Stacked on #14003. Depends on modeling-api #1442, format #925, and engine #5303. The API revision, Cargo lock entries, and Nix source hash are updated, and modeling-command bindings are regenerated.

Request-recording regressions cover exact non-UTF-8 bytes, nested buffer dependencies, unused assets, repeated imports, cached file changes, mock execution, failure/recovery, cross-drive paths, and unresolved traversal. A Studio import/export smoke test with the updated engine remains necessary before landing.

@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Oct 8, 2026 6:37pm UTC

Request Review

@codspeed

codspeed Bot commented Oct 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 157 untouched benchmarks
⏩ 131 skipped benchmarks1


Comparing codex/gltf-imported-files (571e94d) with codex/export-kcl-source (63a4731)

Open in CodSpeed

Footnotes

  1. 131 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This branch was successfully deployed

1 active deployment
Preview — 571e94dd Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant