Repository navigation
Allow original imported files on glTF export commands - #1442
Draft
Joe-Spencer wants to merge 1 commit into
Draft
Joe-Spencer wants to merge 1 commit into
Joe-Spencer wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/export-kcl-source #1442 +/- ##
===========================================================
+ Coverage 36.12% 36.64% +0.51%
===========================================================
Files 32 32
Lines 1733 1733
===========================================================
+ Hits 626 635 +9
+ Misses 1107 1098 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamchalmers
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
exportandexport3dto carry an optionalimported_filesarray of original project-relative paths and raw bytes. glTF exports use it to retain imported CAD inputs and dependent files alongside KCL source; other output formats ignore it. ReuseImportFileso binary contents retain their existing wire encoding and redacted debug behavior.Stacked on #1393. Older requests and builders default to an empty array, and empty arrays are omitted from serialized commands. JSON/BSON round-trip tests cover both command variants with non-UTF-8 and empty files; the full websocket OpenAPI schema is regenerated with KCL execution retained.
Companion drafts: format #925, engine #5303, and Studio #14442.