Repository navigation
Run KCL and modeling tools on CPU engines - #310
Merged
Merged
Conversation
harsh181018
approved these changes
Oct 15, 2026
ksbharaj
reviewed
Oct 15, 2026
| for index, view in enumerate(request.views): | ||
| named = isinstance(view, str) | ||
| view_name = view if isinstance(view, str) else f"custom_{index + 1}" | ||
| options = [ |
Contributor
There was a problem hiding this comment.
Setting geometry_only=True makes the existing _collect_session_snapshots bit expensive as it calls session.snapshots() separately for each view. We can fix by making _collect_session_snapshots pass multiple views into one session.snapshots()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run KCL execution, exports, measurements, and persistent modeling sessions on Zoo's CPU engine pool using the published
zoo-kcl>=0.3.192package. This also enables CPU snapshots of executed KCL and imported CAD files. Requirekittycad>=1.8.0for typedtoggle_graphicscommands and responses through the shared modeling transport. Prepares MCP 0.28.11. Supersedes #306.Persistent sessions initialize CPU graphics on the first snapshot, selection, highlight, or camera tool and retain the renderer until the session closes. Disabling graphics resets camera framing, so retaining it preserves
zoom=False, selections, and highlights across tool calls. Geometry-only work skips graphics initialization.