Repository navigation
Run KCL sessions on CPU engines - #306
Closed
JordanNoone wants to merge 2 commits into
Closed
JordanNoone wants to merge 2 commits into
JordanNoone wants to merge 2 commits into
Conversation
Collaborator
|
superseded by #310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run isolated KCL code and project sessions on CPU engines with
geometry_only=True. Snapshots use zoo-kcl's new graphics-toggle support on the same session; caller-owned modeling sessions are unchanged.Draft until a PyPI zoo-kcl release includes KittyCAD/modeling-app#14432 and KittyCAD/modeling-app#14449. Before merging, raise the zoo-kcl minimum in
pyproject.toml, regenerateuv.lockagainst that release, and verify native CPU execution/export/snapshots. The current 0.3.190 lock does not support this option; do not merge or deploy as-is.Ruff, formatting and focused constructor-forwarding checks pass. Existing non-live coverage (excluding the live Engine server suite) reports 471 passed, one skipped and two native credential-test failures from the old package rejecting
geometry_only. Type checking reports the same two unsupported-argument errors. No new tests added; one existing routing assertion updated. Live CPU/output parity remains pending.