Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower time to first read for r-variable files (ACE, OMNI2) and CDF v2 files. Measured in fresh sessions on Julia 1.13.
ds[name](ac_h2_sis)FILLVAL)Array(Float32 2-D)v[1]+v[:,1:1]v[1]+v[:,1:1]rVDRis merged intoVDR, with a newzvarflag.CDFVariableno longer specializes on the variable kind, so r-variables reuse the z-variable specializations.LABL_PTR_*resolution usesArray, which skips DiskArrays indexing. That indexing compiles again for every string width (~60 ms each).ac_h2_sis), and it compilesDict(var.attrib)instead of a singleget.Cost: precompile takes about 1 s longer (~3.5 s → 4.5 s), and the package image grows from 8.7 MB to 10.1 MB. Load time is unchanged at ~66 ms.
Remaining cost, not addressed here: every new
StaticString{N}width or unseeded element type (e.g. Int32 1-D) still costs ~30–100 ms for DiskArrays indexing (v[1],v[:,1:1]).Array(var)avoids it.