Repository navigation
fix: drop NOVARY dimensions of z-variables - #77
Merged
Merged
Conversation
Beforerr
force-pushed
the
fix-novary-z
branch
2 times, most recently
from
October 6, 2026 13:08
44373d5 to
0402510
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NOVARY dimensions aren't physically stored, so counting them read past each variable's data. r-variables already dropped them; z-variables now share that path. Matches CDFpp and cdflib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #76.
z-variables counted NOVARY dimensions, which aren't physically stored, so reads ran past the variable's data and returned unrelated memory. r-variables already dropped them; both kinds now share
_dim_layout. CDFpp (get_variable_dimensions) and cdflib (_read_vdr/_num_values) drop them the same way.Fixture
data/novary_z.cdf(row-major, declared(2,3,4), dim 2 NOVARY): neither cdflib's nor CDFpp's writer honorsDim_Vary, sodata/make_novary_z.pywrites(2,1,4)and patches the zVDR. pycdfpp and cdflib both read it as(5,2,4). Before the fix, we read(2,3,4,5)with garbage values. Full test suite passes.