Repository navigation
Phase 13: every loader on every supported version (1.1.0-beta.9) - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 13 of the road to 1.1.0: every loader on every supported version.
platformsnow holds 21 modules, Forge, NeoForge and Fabric on 26.3, 26.2, 26.1, 1.21.11, 1.21.5, 1.21.1 and 1.20.6, each with phases 8 to 12. 1.20.2 and 1.19.4 are on hold and not part of 1.1.0.Ready to tag as
v1.1.0-beta.9: version bumped, changelog dated, roadmap marked released.Bugs fixed along the way
SoundEnginecalls the buffer library directly and neverSoundInstance.getStream. Reproduced by asking OpenAL whether the channel plays, with NeoForge as the control.PackSoundBuffersreplaces the library onSoundEngineLoadEvent, through a new access transformer entry.AircraftRotation.rollInXyzOrderworks out the angles, with unit tests against the view every other version builds.pack.mcmetawithmin_format75 satisfies both the resource and data validators. The range now starts at 82. Resources and data still load on all three loaders.How it was checked
A throwaway driver ran real dev clients on all 21 modules. On each it loaded the world, got 128 recipes, opened the drafting table, workshop and vehicle screens, sat in the seat, loaded the example pack, spawned its vehicle and played a pack sound through the server's packet (OpenAL reports it playing).
./gradlew buildpasses, and all 21 jars were listed for leftovers.Not checked
These moved to the 1.1.0 section of
docs/ROADMAP.md, or are listed per version indocs/TESTING.md.