Repository navigation
autodev: reviewer policy object, config checks split, shared check runner - #49
Merged
Merged
Conversation
…nner, one retry decision No behaviour change. review.py takes a Reviewers (permissions, bot, allow_self, marker_prefix) instead of four positional arguments on each function; approved() goes from 8 parameters to 5, feedback() from 7 to 4. Config._finish calls _check_github, _resolve_paths, _check_agent and _check_mounts. The ok/BAD table in `check` is run_checks() in autodev.cli, used by both CLIs. GitHub.request asks _retry_delay once for 5xx and rate limits instead of two branches, and the ETag bookkeeping is _remember_etag. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second half of the structural cleanup (first half: #48). No behaviour change; in-flight workflows are not affected (no activity input or result changes, no workflow code touched).
review.py: the four "who counts" arguments (permissions,bot,allow_self,marker_prefix) are oneReviewersdataclass withis_human_writerandis_ours.approvedgoes from 8 parameters to 5,feedbackfrom 7 to 4;handled_idsandlatest_round_attake it too.config.py:_finishcalls_check_github,_resolve_paths,_check_agent,_check_mounts, mirroring mia-data's config after mia-data: split the poller, simplify the job builders and the checks #48. Messages unchanged.cli.py: the ok/BAD table loop isrun_checks(checks), shared withmia check; the autodevcheckcloses its own client inrepoinstead of anonlocal.github.py:_rate_limit_delaybecomes_retry_delay, covering 5xx too, so the request loop asks one question; ETag bookkeeping is_remember_etag. The retry log line now says the status and delay for both cases.Left alone:
_watch_pr(a state machine whose branches are the actions; splitting it across methods would make the replay-determinism story harder to read),request's nine keyword parameters (its public surface) anddecide's seven returns (one per action).🤖 Generated with Claude Code