Repository navigation
Conversation
Defaults except max-args 6 and max-returns 8; tests are exempt from C901 and PLR0913 (fake dispatchers are one switch each). The nine functions over the line keep a noqa with the reason on the same line. RUF100 catches a noqa that no longer suppresses anything (one stale BLE001 removed). The guide says what the limits are and that a new noqa needs a reason. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #48 and #49, which brought the code to where these rules can be switched on. Config only plus nine
noqalines and a guide paragraph; no code change.C901(complexity 10),PLR0912(12 branches),PLR0915(50 statements),PLR0911(8 returns:decideand_roundreturn once per outcome),PLR0913(6 parameters: more wants a parameter object likeJobArgsorReviewers), andRUF100so anoqathat stops suppressing anything fails lint.C901andPLR0913: the fake activity dispatchers and fake services are one big switch each by design.noqaline:GitHub.request,_watch_pr,render_prompt, miaActivities.__init__,check_binding,run_test_pr,run_crop_test,_spec,publish.noqa: BLE001intest_mia_publish.pythatRUF100found.docs/development.mdstates the limits and that the list of exceptions does not grow without a reason.🤖 Generated with Claude Code