fix(api): preserve closeOwnerAuthors in settings schemas and routes#1564
Merged
JSONbored merged 1 commit intoJun 27, 2026
Merged
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1564 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 202 202
Lines 21674 21674
Branches 7833 7833
=======================================
Hits 20683 20683
Misses 416 416
Partials 575 575
🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
closeOwnerAuthorsrepository setting was stored and used internally but omitted from the HTTP/Zod schemas, so API writes to maintainer, ai-review, and internal settings endpoints were stripped or reset to the DB default.Description
closeOwnerAuthorsto the Zod schemas:repositorySettingsSchema,maintainerSettingsSchema, andrepositoryAiReviewSchemainsrc/api/routes.tsso requests can carry the field.closeOwnerAuthorsfrom the AI-review route and the internal full-settings route by includingcloseOwnerAuthors: parsed.data.closeOwnerAuthorswhen callingupsertRepositorySettings.test/unit/routes-ai-byok.test.tsto cover setting/persistence via the AI-review route, maintainer settings route, and internal settings route, and to assert the default when omitted.npm run ui:openapito reflect the API surface change.Testing
npx vitest run test/unit/routes-ai-byok.test.ts --reporter verbose, and all tests in that file passed (19/19).npm run ui:openapiandnpm run ui:openapi:check, both succeeded and wrote/validatedapps/gittensory-ui/public/openapi.json.git diff --checkpassed locally.npm run typecheckfailed due to a pre-existing missing@sentry/nodetypes issue insrc/selfhost/sentry.ts, and a fullnpm run test:coveragerun produced a V8 coverage remapping error (TypeError: jsTokens is not a function) after the targeted tests ran;npm run test:ciis blocked by external actionlint/network environment issues andnpm auditwas blocked by a 403 from the npm audit endpoint.Codex Task