fix(selfhost): probe Qdrant /readyz for readiness#1565
Merged
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 202 202
Lines 21674 21675 +1
Branches 7833 7833
=======================================
+ Hits 20683 20684 +1
Misses 416 416
Partials 575 575
🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/readyprobe queried the rawQDRANT_URLwithout the configuredQDRANT_API_KEYand without using Qdrant's documented unauthenticated/readyzendpoint, causing healthy API-key-protected Qdrant deployments to make the instance report503.Description
qdrantReadyzUrl(url: string)insrc/selfhost/qdrant-vectorize.tsto normalize a configured Qdrant base URL and produce the unauthenticated/readyzURL.src/server.tsto callqdrantReadyzUrl(qdrantUrl)instead of fetching the raw base URL, while leaving authenticated collection initialization viainitQdrantCollection()unchanged.test/unit/selfhost-qdrant-vectorize.test.tsto assert/readyzis chosen for both plain and trailing-slash base URLs.Testing
npx vitest run test/unit/selfhost-qdrant-vectorize.test.ts, and the tests passed successfully.npm run typecheck, which failed in this environment due to missing@sentry/nodetype declarations unrelated to the change.npx vitest run --coverage test/unit/selfhost-qdrant-vectorize.test.ts, which exercised tests but coverage remapping failed here withTypeError: jsTokens is not a function(environmental tooling issue).npm run test:ciandnpm audit --audit-level=moderate, both of which failed in this environment due to external tool/registry issues (actionlint/runner-label DNS fallback and npm audit 403) and not because of the PR logic or behaviour.Codex Task