fix(review): gate placeholder on actual AI eligibility

[JSONbored]

Motivation

• The transient 🟪 "reviewing…" placeholder could be posted even when the AI path would not run, producing misleading public output and unnecessary GitHub writes.
• The original placeholder predicate used a coarse aiReviewWillRun that omitted feature-flag, binding, contributor, and reputation checks that the real AI path enforces.

Description

• Add a shared shouldStartAiReviewForAdvisory predicate in src/queue/processors.ts that mirrors the AI review entry gates including skip flag, aiReviewMode, confirmed-contributor handling (with oss-anti-slop exception), presence of headSha, AI_SUMMARIES_ENABLED, AI_PUBLIC_COMMENTS_ENABLED, Workers-AI binding (env.AI), and the reputation downgrade check.
• Import isEnabled from src/services/ai-review and use the new predicate where the placeholder decision is made, replacing the coarse aiReviewWillRun boolean so the placeholder is only posted when the AI review would actually start.
• Add unit tests for the new predicate in test/unit/ai-review-advisory.test.ts that cover skip flag, mode off, contributor eligibility, missing head SHA, disabled public comments / missing binding, and the reputation downgrade path.
• Add a regression test in test/unit/queue.test.ts asserting that disabled public AI comments do not post the 🟪 placeholder and that the model is not invoked.

Testing

• Ran the focused unit tests with npx vitest run test/unit/ai-review-advisory.test.ts test/unit/queue.test.ts -t "shouldStartAiReviewForAdvisory|reviewing placeholder", and the targeted suites passed.
• Ran npm run typecheck and the TypeScript checks passed.
• Attempted the full local gate npm run test:ci, but the environment hit unrelated tool/network issues during a full coverage run (V8 coverage remap error: TypeError: jsTokens is not a function) so the end-to-end local CI was not completed in this environment.
• Attempted npm audit --audit-level=moderate, but the audit endpoint returned 403 Forbidden from the environment, so dependency-audit could not be completed here.

---

Codex Task

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.37%. Comparing base (9e1c351) to head (4e411b8).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   95.38%   95.37%   -0.02%     
==========================================
  Files         201      201              
  Lines       21598    21601       +3     
  Branches     7807     7810       +3     
==========================================
  Hits        20601    20601              
- Misses        416      417       +1     
- Partials      581      583       +2     

Files with missing lines	Coverage Δ
src/queue/processors.ts	87.24% <100.00%> (-0.19%)	⬇️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gittensory-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review — held for maintainer review

3 files · 1 AI reviewers · no blockers · readiness 48/100 · CI green · blocked

⏸️ Held for maintainer review

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewers, synthesized
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	⚠️ 3 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Review load	❌ 8/20	Readiness component derived from cached public PR metadata and labels; size label size:M.
Validation evidence	❌ 5/25	Cached preflight status is hold.
Open PR queue	❌ 3/10	48 open PR(s), 9 likely reviewable, 39 unlinked.
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 81 PR(s), 261 issue(s).
Gate result	✅ Passing	No configured blocker found.

Nits — 2 non-blocking

• Repository config was not parsed
• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 81 PR(s), 261 issue(s).
• Related work: Titles/paths share 6 meaningful terms. (PR #1391)
• Related work: Titles/paths share 6 meaningful terms. (PR #1396)
• Related work: Titles/paths share 7 meaningful terms. (PR #1398)
• Additional title-only matches omitted; title-only overlap does not block.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Explain no-issue PR.
• Review top overlaps.
• Add scope summary.
• Fix blocker.
• Expect slower review.
• Refresh registry data or choose a registered active repo.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
• Open PR queue = repo-wide review pressure; it is not a PR quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review