Skip to content

fix(review): refresh PR files when pre-merge checks are path-gated#1402

Merged
JSONbored merged 3 commits into
mainfrom
codex/fix-path-gated-pre-merge-check-vulnerability
Jun 27, 2026
Merged

fix(review): refresh PR files when pre-merge checks are path-gated#1402
JSONbored merged 3 commits into
mainfrom
codex/fix-path-gated-pre-merge-check-vulnerability

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Path-scoped review.pre_merge_checks (entries with when_paths) rely on accurate PR file lists to decide whether an enforced check applies, and stale cached pull_request_files could let an enforced check be incorrectly ignored.

Description

  • Add shouldRefreshFilesForPreMergeChecks(env, repoFullName) to detect whether the repo manifest contains any pre_merge_checks with when_paths.
  • Wire that predicate into stored re-review, pull_request webhook synchronize/processing, and manual re-run paths so refreshPullRequestDetails runs when path-gated checks are configured.
  • Add a unit test for the refresh predicate in test/unit/gate-check-policy.test.ts and a synchronize regression test that seeds stale cached files and verifies a live files fetch replaces them in test/unit/queue.test.ts.

Testing

  • Ran git diff --check and npm run typecheck, both succeeded.
  • Ran targeted unit tests with npx vitest run test/unit/gate-check-policy.test.ts test/unit/queue.test.ts -t "refreshes files when pre-merge checks|refreshes pull request files for path-gated pre-merge checks" and the new/affected tests passed.
  • Attempted full npm run test:ci; the run progressed but could not be completed in this environment (coverage phase / long-running CI step was stopped).
  • npm audit --audit-level=moderate could not complete due to the registry audit endpoint returning 403 Forbidden in this environment.

Codex Task

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 26, 2026
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (9e1c351) to head (b3524a3).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1402   +/-   ##
=======================================
  Coverage   95.38%   95.39%           
=======================================
  Files         201      201           
  Lines       21598    21601    +3     
  Branches     7807     7807           
=======================================
+ Hits        20601    20606    +5     
+ Misses        416      415    -1     
+ Partials      581      580    -1     
Files with missing lines Coverage Δ
src/queue/processors.ts 87.59% <100.00%> (+0.16%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored self-assigned this Jun 26, 2026
@JSONbored JSONbored added the gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. label Jun 26, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 26, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 81f1b63 Commit Preview URL

Branch Preview URL
Jun 26 2026, 07:05 AM

@JSONbored JSONbored force-pushed the codex/fix-path-gated-pre-merge-check-vulnerability branch from 81f1b63 to e3fe950 Compare June 26, 2026 21:00
@gittensory-orb

gittensory-orb Bot commented Jun 27, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review — held for maintainer review

3 files · 1 AI reviewers · no blockers · readiness 48/100 · CI green · blocked

⏸️ Held for maintainer review

Signal Result Evidence
Code review ✅ No blockers 1 reviewers, synthesized
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels; size label size:S.
Validation evidence ❌ 5/25 Cached preflight status is hold.
Open PR queue ❌ 3/10 48 open PR(s), 9 likely reviewable, 39 unlinked.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 81 PR(s), 261 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 2 non-blocking
  • Repository config was not parsed
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 81 PR(s), 261 issue(s).
  • Related work: Titles/paths share 6 meaningful terms. (PR #1391)
  • Related work: Titles/paths share 7 meaningful terms. (PR #1396)
  • Related work: Titles/paths share 6 meaningful terms. (PR #1441)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Review top overlaps.
  • Add scope summary.
  • Fix blocker.
  • Expect slower review.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot added the gittensor Gittensor contributor context label Jun 27, 2026
@JSONbored JSONbored merged commit 4144a93 into main Jun 27, 2026
19 checks passed
@JSONbored JSONbored deleted the codex/fix-path-gated-pre-merge-check-vulnerability branch June 27, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark codex gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. gittensor Gittensor contributor context size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant