Repository navigation
Add geovals for the SeaIceFreeboard operator test - #601
Conversation
|
I was about to say that 8000 locs seems like an overkill for a ufo test, but looks like @rajichidamb has fixed it, thank you! |
I just compressed the file, left the location as is |
BenjaminRuston
left a comment
There was a problem hiding this comment.
very nice addition many thanks @guillaumevernieres
rajichidamb
left a comment
There was a problem hiding this comment.
Thanks @guillaumevernieres
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
There was a problem hiding this comment.
Previously geoval reading Netcdf file set the values greater than 1.0e8 to be missing value, the cryosat2-2018-04-15_seaicefreeboard_geovals.nc file has no _FillValue attribute and set values of 1e20 are missing. So the data file needs to be updated with double/float fill missing attribute to match the geoval update to read and check values in netcdf.
There was a problem hiding this comment.
@rajichidamb , @BenjaminRuston and @shlyaeva : I'm going to cut-down the size to ~100 obs locations which will require updating the reference for a test unrelated to my ufo PR. Are you OK with this?
There was a problem hiding this comment.
yes go for it please 😃
and thanks!
|
@guillaumevernieres looking at associated UFO PR you may be generating new input, sync with develop if you can before pushing |
@BenjaminRuston , Let's wait before merging this, I'm going to reduce the freeboard obs count to ~100. |
no worries just prod me here or in the UFO PR when it's ready |
rajichidamb
left a comment
There was a problem hiding this comment.
Thanks @guillaumevernieres. This has reduced the file sizes.
Description
Adds
testinput_tier_1/cryosat2-2018-04-15_seaicefreeboard_geovals.nc, the geovals for the newSeaIceFreeboardoperator tests in ufo.The file has the 8065 locations of
cryosat2-2018-04-15_geovals.nc, but with single-category (per unit ice area)sea_ice_thickness,sea_ice_snow_thicknessandsea_ice_area_fraction. The existing file has 5 categories, all with the same values everywhere. The new fields are synthetic and vary smoothly with latitude and longitude:A few locations have missing ice or snow thickness, to test the operator's missing-value handling.
build-group=https://github.com/JCSDA-internal/ufo/pull/4395
Issue(s) addressed
Works toward jcsda-internal/ufo/issues/4388
Dependencies
None. The companion ufo PR (jcsda-internal/ufo/pull/<#>) depends on this one.
Impact
None. This is a new file and no existing data is modified.
Need for: https://github.com/JCSDA-internal/ufo/pull/4395
Checklist