Skip to content

Add geovals for the SeaIceFreeboard operator test - #601

Merged
BenjaminRuston merged 8 commits into
developfrom
feature/seaicefreeboard
Oct 22, 2026
Merged

BenjaminRuston merged 8 commits into
developfrom
feature/seaicefreeboard

Conversation

@guillaumevernieres

@guillaumevernieres guillaumevernieres commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds testinput_tier_1/cryosat2-2018-04-15_seaicefreeboard_geovals.nc, the geovals for the new SeaIceFreeboard operator tests in ufo.

The file has the 8065 locations of cryosat2-2018-04-15_geovals.nc, but with single-category (per unit ice area) sea_ice_thickness, sea_ice_snow_thickness and sea_ice_area_fraction. The existing file has 5 categories, all with the same values everywhere. The new fields are synthetic and vary smoothly with latitude and longitude:

  • ice thickness 1.6–3.8 m
  • snow thickness 0.16–0.42 m
  • ice fraction 0.53–0.96

A few locations have missing ice or snow thickness, to test the operator's missing-value handling.

build-group=https://github.com/JCSDA-internal/ufo/pull/4395

Issue(s) addressed

Works toward jcsda-internal/ufo/issues/4388

Dependencies

None. The companion ufo PR (jcsda-internal/ufo/pull/<#>) depends on this one.

Impact

None. This is a new file and no existing data is modified.

Need for: https://github.com/JCSDA-internal/ufo/pull/4395

Checklist

  • I have performed a self-review of my own code
  • I have run the unit tests before creating the PR

@BenjaminRuston BenjaminRuston added the coordinated merge Needs to be coordinated with other repos label Oct 2, 2026
@shlyaeva

shlyaeva commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

I was about to say that 8000 locs seems like an overkill for a ufo test, but looks like @rajichidamb has fixed it, thank you!

@rajichidamb

Copy link
Copy Markdown
Contributor

I was about to say that 8000 locs seems like an overkill for a ufo test, but looks like @rajichidamb has fixed it, thank you!

I just compressed the file, left the location as is

@BenjaminRuston
BenjaminRuston self-requested a review October 19, 2026 14:40
@BenjaminRuston BenjaminRuston added the ready for merge PR is reviewed and is ready for merge label Oct 19, 2026

@BenjaminRuston BenjaminRuston left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice addition many thanks @guillaumevernieres

@BenjaminRuston BenjaminRuston added needs review Asking others to review - often used for pull requests and removed ready for merge PR is reviewed and is ready for merge labels Oct 19, 2026

@rajichidamb rajichidamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenjaminRuston BenjaminRuston added ready for merge PR is reviewed and is ready for merge and removed needs review Asking others to review - often used for pull requests labels Oct 19, 2026
@BenjaminRuston BenjaminRuston mentioned this pull request Oct 19, 2026
2 of 3 tasks
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously geoval reading Netcdf file set the values greater than 1.0e8 to be missing value, the cryosat2-2018-04-15_seaicefreeboard_geovals.nc file has no _FillValue attribute and set values of 1e20 are missing. So the data file needs to be updated with double/float fill missing attribute to match the geoval update to read and check values in netcdf.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajichidamb , @BenjaminRuston and @shlyaeva : I'm going to cut-down the size to ~100 obs locations which will require updating the reference for a test unrelated to my ufo PR. Are you OK with this?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes go for it please 😃

and thanks!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

@BenjaminRuston

Copy link
Copy Markdown
Collaborator

@guillaumevernieres looking at associated UFO PR you may be generating new input, sync with develop if you can before pushing

@BenjaminRuston BenjaminRuston removed the ready for merge PR is reviewed and is ready for merge label Oct 19, 2026
@guillaumevernieres

Copy link
Copy Markdown
Contributor Author

@guillaumevernieres looking at associated UFO PR you may be generating new input, sync with develop if you can before pushing

@BenjaminRuston , Let's wait before merging this, I'm going to reduce the freeboard obs count to ~100.

@BenjaminRuston

Copy link
Copy Markdown
Collaborator

@guillaumevernieres

Let's wait before merging this, I'm going to reduce the freeboard obs count to ~100.

no worries just prod me here or in the UFO PR when it's ready

@rajichidamb rajichidamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guillaumevernieres. This has reduced the file sizes.

@BenjaminRuston BenjaminRuston added the ready for merge PR is reviewed and is ready for merge label Oct 21, 2026
@BenjaminRuston
BenjaminRuston merged commit 60042ee into develop Oct 22, 2026
2 checks passed
@BenjaminRuston
BenjaminRuston deleted the feature/seaicefreeboard branch October 22, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coordinated merge Needs to be coordinated with other repos ready for merge PR is reviewed and is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants