Skip to content

Fix malformed mpi_rank.nc4 file. - #604

Merged
BenjaminRuston merged 2 commits into
developfrom
bugfix/malformed_mpi_file
Oct 19, 2026
Merged

BenjaminRuston merged 2 commits into
developfrom
bugfix/malformed_mpi_file

Conversation

@lewisn-met

Copy link
Copy Markdown
Contributor

Description

This PR updates the mpi_rank.nc4 file to conform to the variable dimensioning rules enforced by the new OSDF container in Ioda.

The netCDF file in question was used as input for a pair of UFO tests and verified functionality of time window filtering with varying numbers of MPI ranks. However, in this input file, dateTime, longitude, and latitude were all given 1D slice dimension LocationAll rather than Location, which caused the tests to fail when the OSDF was turned on.

By setting these variables to have dimension Location which is resized from 7 to 9 (with the remaining variables originally dimensioned by Location being padded with junk data at the excluded times), the two tests now pass with both the ObsGroup and OSDF.

Issue(s) addressed

Resolves https://github.com/JCSDA-internal/ioda/issues/1925

Dependencies

N/A

Impact

Expected impact on downstream repositories: N/A

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@lewisn-met lewisn-met self-assigned this Oct 13, 2026
@lewisn-met lewisn-met added the INTERFACE JEDI Models Interface label Oct 13, 2026

@ctgh ctgh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@srherbener srherbener left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! I confirmed in my OSDF testing that this fixes the two targeted UFO test failures, and did not introduce any regressions. The total jedi-bundle test failures count is down to 13!

@BenjaminRuston

Copy link
Copy Markdown
Collaborator

let me merge PR601 first @srherbener then will put this one in next

@BenjaminRuston BenjaminRuston added the ready for merge PR is reviewed and is ready for merge label Oct 19, 2026
@srherbener

Copy link
Copy Markdown
Collaborator

Thanks @BenjaminRuston!

@BenjaminRuston
BenjaminRuston merged commit f129187 into develop Oct 19, 2026
2 checks passed
@BenjaminRuston
BenjaminRuston deleted the bugfix/malformed_mpi_file branch October 19, 2026 18:08
@srherbener

Copy link
Copy Markdown
Collaborator

Awesome! Thanks for getting this merged so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

INTERFACE JEDI Models Interface ready for merge PR is reviewed and is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants