Repository navigation
Fix malformed mpi_rank.nc4 file. - #604
Merged
Merged
Conversation
lewisn-met
requested review from
ctgh,
mikecooke77,
samueljmcameron,
srherbener and
svahl991
October 13, 2026 13:57
srherbener
approved these changes
Oct 14, 2026
srherbener
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this update! I confirmed in my OSDF testing that this fixes the two targeted UFO test failures, and did not introduce any regressions. The total jedi-bundle test failures count is down to 13!
Collaborator
|
let me merge PR601 first @srherbener then will put this one in next |
Collaborator
|
Thanks @BenjaminRuston! |
Collaborator
|
Awesome! Thanks for getting this merged so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the mpi_rank.nc4 file to conform to the variable dimensioning rules enforced by the new OSDF container in Ioda.
The netCDF file in question was used as input for a pair of UFO tests and verified functionality of time window filtering with varying numbers of MPI ranks. However, in this input file,
dateTime,longitude, andlatitudewere all given 1D slice dimensionLocationAllrather thanLocation, which caused the tests to fail when the OSDF was turned on.By setting these variables to have dimension
Locationwhich is resized from 7 to 9 (with the remaining variables originally dimensioned by Location being padded with junk data at the excluded times), the two tests now pass with both the ObsGroup and OSDF.Issue(s) addressed
Resolves https://github.com/JCSDA-internal/ioda/issues/1925
Dependencies
N/A
Impact
Expected impact on downstream repositories: N/A
Checklist