Skip to content

fix: always show purchased domain renewal state - #343

Open
Fermionic-Lyu wants to merge 1 commit into
mainfrom
codex/domain-renewal-status
Open

Fermionic-Lyu wants to merge 1 commit into
mainfrom
codex/domain-renewal-status

Conversation

@Fermionic-Lyu

@Fermionic-Lyu Fermionic-Lyu commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Purchased-domain list/status output hides automatic renewal whenever the expiry date is unavailable, and silence is also the only indication that renewal is off. Always print auto-renew on|off, independently of the optional expiry date. JSON and domain settings are unchanged.

Addresses the display portion of #230; the setting command remains open. No new CLI leaf or MCP capability is introduced.

Validation: typecheck; all 1,998 tests; independent review; all eight renewal/expiry mutation checks fail as expected. First push: +11/-2, two files.


Summary by cubic

Always show purchased domain renewal state in list/status output, even when no expiry date is available. The domain list previously hid auto-renew status whenever the expiry date was missing, and silence was the only sign renewal was off. Renewal state now prints as auto-renew on|off separately from the optional expiry date.

Addresses the display portion of #230; the setting command remains open. JSON output and domain settings are unchanged.

Written for commit d0c3246. Summary will update on new commits.

Review in cubic

@agent-zhang-beihai agent-zhang-beihai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Wang Miao

This change makes the purchased-domain header line always show auto-renew on|off. Before, the renewal state only appeared when there was an expiry date, and only when auto-renew was on. I found no findings, so I'd approve it.

I checked that the platform always sends autorenew: it is not null default true in instacloud-platform migrations/0066_domain_purchase.sql:66, a required field in openapi.yaml, and always set in src/domains/service.ts:224. So the new off branch never shows for a value that is just missing. The only place the old auto-renews wording was pinned is the test this PR updates; nothing in instacloud-skills mentions it. I couldn't run the tests because dependencies aren't installed in this checkout, so the verdict comes from reading the code.

@agent-zhang-beihai agent-zhang-beihai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Yang Dong

This makes purchased-domain renewal status visible even when no expiry date is available, while clearly representing both enabled and disabled renewal. The implementation and coverage are correct; I approve with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@Fermionic-Lyu

Copy link
Copy Markdown
Member Author

Both requested reviews approve. Linux CI failed in the unchanged test/ssh-orchestration.test.ts stale-lock concurrency test (two contenders entered together); this PR only touches domain display and its tests. Windows and local full-suite runs pass. Re-running the failed job once; no unrelated lock changes are included.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant