Repository navigation
fix: always show purchased domain renewal state - #343
Fermionic-Lyu wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Reviewed by Wang Miao
This change makes the purchased-domain header line always show auto-renew on|off. Before, the renewal state only appeared when there was an expiry date, and only when auto-renew was on. I found no findings, so I'd approve it.
I checked that the platform always sends autorenew: it is not null default true in instacloud-platform migrations/0066_domain_purchase.sql:66, a required field in openapi.yaml, and always set in src/domains/service.ts:224. So the new off branch never shows for a value that is just missing. The only place the old auto-renews wording was pinned is the test this PR updates; nothing in instacloud-skills mentions it. I couldn't run the tests because dependencies aren't installed in this checkout, so the verdict comes from reading the code.
|
Both requested reviews approve. Linux CI failed in the unchanged test/ssh-orchestration.test.ts stale-lock concurrency test (two contenders entered together); this PR only touches domain display and its tests. Windows and local full-suite runs pass. Re-running the failed job once; no unrelated lock changes are included. |
Purchased-domain list/status output hides automatic renewal whenever the expiry date is unavailable, and silence is also the only indication that renewal is off. Always print
auto-renew on|off, independently of the optional expiry date. JSON and domain settings are unchanged.Addresses the display portion of #230; the setting command remains open. No new CLI leaf or MCP capability is introduced.
Validation: typecheck; all 1,998 tests; independent review; all eight renewal/expiry mutation checks fail as expected. First push: +11/-2, two files.
Summary by cubic
Always show purchased domain renewal state in list/status output, even when no expiry date is available. The domain list previously hid auto-renew status whenever the expiry date was missing, and silence was the only sign renewal was off. Renewal state now prints as
auto-renew on|offseparately from the optional expiry date.Addresses the display portion of #230; the setting command remains open. JSON output and domain settings are unchanged.
Written for commit d0c3246. Summary will update on new commits.