Fold OSV advisories into vulnerabilities in the domain - #222
Merged
Conversation
Reading several databases' advisories as one vulnerability lived in `sources.osv`, in an `Advisory` type and a `Defect` type holding a group of them. `Vulnerability` now carries it, through `identifiers`, `names`, and `merged`, and never lists its own advisory id among its aliases. The source reads each record into a `Vulnerability` and folds them, so both types are gone. Behaviour is unchanged, down to which id a vulnerability is reported under. The README, the docstrings, and the test names now say "vulnerability" for the thing warned about and "advisory" for one database's report of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading several databases' advisories as one vulnerability lived in
sources.osv, in anAdvisorytype and aDefecttype holding a group of them.Vulnerabilitynow carries it, throughidentifiers,names, andmerged, and never lists its own advisory id among its aliases. The source reads each record into aVulnerabilityand folds them, so both types are gone. Behaviour is unchanged, down to which id a vulnerability is reported under. The README, the docstrings, and the test names now say "vulnerability" for the thing warned about and "advisory" for one database's report of it.