Skip to content

Added pyhubblenetwork.yml workflow - #23

Merged
hunterhubble merged 1 commit into
HubbleNetwork:mainfrom
hunterhubble:ci-HUB-5440-clean
Jun 26, 2026
Merged

Added pyhubblenetwork.yml workflow#23
hunterhubble merged 1 commit into
HubbleNetwork:mainfrom
hunterhubble:ci-HUB-5440-clean

Conversation

@hunterhubble

Copy link
Copy Markdown
Contributor
  • Runs pyhubblenetwork tests for each PR to sdr-docker.
  • Also gives option to build image with local version of hubble-satnet-decoder. This is to run CI tests with sdr-docker on pyhubblenetwork with PRs to hubble-satnet-decoder

@hunterhubble

Copy link
Copy Markdown
Contributor Author

Coincides with PRs to pyhubblenetwork and hubble-satnet-decoder
HubbleNetwork/pyhubblenetwork#39
HubbleNetwork/hubble-satnet-decoder#8

@hunterhubble

Copy link
Copy Markdown
Contributor Author

@HongNguyen635 HongNguyen635 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Also, can you squash these 2 commits? Looks like the 2nd commit is just fixing the 1st.

branches: [main]
pull_request:
branches: [main]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a public repo, probably worth it to put this?

permissions:
  contents: read

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Comment thread .github/workflows/pyhubblenetwork.yml Outdated
python-version: "3.12"

- name: Build local image
run: mkdir -p decoder-src && docker build -t sdr-docker:pr-test .

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker build from scratch every time, is this intended? Otherwise we can cache it from docker GH action to speed up the process since the build is quite heavy.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, didn't think of this, let me look into ways to do this.

- Runs pyhubblenetwork tests for each PR to sdr-docker.
- Also gives option to build image with local version of
hubble-satnet-decoder. This is to run CI tests with sdr-docker
on pyhubblenetwork with PRs to hubble-satnet-decoder

Signed-off-by: hunterhubble <hunter@hubble.com>
@hunterhubble
hunterhubble merged commit f92c574 into HubbleNetwork:main Jun 26, 2026
5 checks passed
@hunterhubble
hunterhubble deleted the ci-HUB-5440-clean branch June 26, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants