Skip to content

Add workflow to run pyhubblenetwork CI tests - #8

Merged
hunterhubble merged 1 commit into
HubbleNetwork:mainfrom
hunterhubble:ci-HUB-5440
Jun 27, 2026
Merged

Add workflow to run pyhubblenetwork CI tests#8
hunterhubble merged 1 commit into
HubbleNetwork:mainfrom
hunterhubble:ci-HUB-5440

Conversation

@hunterhubble

Copy link
Copy Markdown
Contributor
  • On PRs to hubble-satnet-decoder, run sdr-docker, which will build with a local copy of hubble-satnet-decoder (not pip install), and then runs the pyhubblenetwork CI tests

@hunterhubble

Copy link
Copy Markdown
Contributor Author

@HongNguyen635

HongNguyen635 commented Jun 26, 2026

Copy link
Copy Markdown

I'm thinking do we need this? If we think about it, it seems circular in a sense that a PR to either 1 of these 3 (sdr-docker, satnet decoder, pyhubblenetwork) will trigger a rebuild. It doesn't neccessary means that it'll pass.

The layer of dependencies are: pyhubblenetwork -> depends on -> sdr-docker -> depends on -> this repo (satnet decoder). For example, if there is a protocol change, the upper layer is definitely going to fail.

@hunterhubble

Copy link
Copy Markdown
Contributor Author

I'm thinking do we need this? If we think about it, it seems circular in a sense that a PR to either 1 of these 3 (sdr-docker, satnet decoder, pyhubblenetwork) will trigger a rebuild. It doesn't neccessary means that it'll pass.

The layer of dependencies are: pyhubblenetwork -> depends on -> sdr-docker -> depends on -> this repo (satnet decoder). For example, if there is a protocol change, the upper layer is definitely going to fail.

I agree it's not a thorough test, it is not meant to test the decoder, maybe I can look into how to validate the decoder against another source of truth. This is more of a smoke test to ensure that the changes to hubble-satnet-decoder still lets us build sdr-docker and use the pyhubblenetwork tools as we normally could.

@HongNguyen635

Copy link
Copy Markdown

@hunterhubble I re-ran CI because the PR that you added for running pyhubblenetwork tests just got merged to sdr-docker and looks like there's an error

@hunterhubble

Copy link
Copy Markdown
Contributor Author

@hunterhubble I re-ran CI because the PR that you added for running pyhubblenetwork tests just got merged to sdr-docker and looks like there's an error

Thank you for looking, I'll try and see why that is

- On PRs to hubble-satnet-decoder, run sdr-docker, which will build with a
local copy of hubble-satnet-decoder (not pip install), and then runs the
pyhubblenetwork CI tests

Signed-off-by: hunterhubble <hunter@hubble.com>
@hunterhubble

Copy link
Copy Markdown
Contributor Author

@HongNguyen635 found the issue, the way I copied the /decoder-src directory to sdr-docker so that it could build with the local version of hubble-satnet-decoder instead of the pip was not compatible with the gh action to build the container. This new way does that correctly and it just passed. Thank you for flagging

@HongNguyen635 HongNguyen635 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Your explanation about why you added this workflow makes sense to me.

@hunterhubble
hunterhubble merged commit 1278f0f into HubbleNetwork:main Jun 27, 2026
3 checks passed
@hunterhubble
hunterhubble deleted the ci-HUB-5440 branch June 27, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants