Repository navigation
kernel D2 K1: the pool vocabulary leaves failover/ for config/pools.rs - #933
Merged
Merged
Conversation
`CandidatePoolCfg` (the `tool_pools:`/`agent_pools:` serde shape), `Repeatable`, and the failover budget's defaults and bound (`DEFAULT_FAILOVER_CAP`, `DEFAULT_FAILOVER_DEADLINE_SECS`, `MAX_FAILOVER_DEADLINE_SECS`) are configuration, not walk machinery. They move verbatim into `config/pools.rs` beside `FailoverCfg`, whose serde defaults read them. `failover/` keeps only the walk (`walk`, `walk_with`, `record_*`, `Candidate`, `Stage`, `Refusal`, `Admitted`, `Attempt`, `Order`, `InOrder`), whose only callers are the legacy plane crates, so the directory deletes whole with busbar-a2a (#787) and busbar-llm (row 155 C). Until then `failover` re-exports the moved items at their historical path for the callers that still spell it so (root serve.rs and its tests, the legacy crates). Kernel-internal callers (state.rs, config/mod.rs) now name `config::pools` directly. The config-schema gate's source list drops `failover/mod.rs`: the type is fingerprinted by name, and `config/pools.rs` is already tracked through the kernel's grammar directory, so the snapshot does not move. core-admin reads `APPLICATION_JSON` from its defining home, `busbar_contract::protocol`, not through the kernel's `proxy` facade. Intra-kernel move: no behaviour change, no ceiling change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KERNEL-DELETE lane, slice K1 (TODO l.24-27, /status row 82; ARCHITECT R-A 2026-10-14: neutral code stays in the kernel under a home named by what it does).
CandidatePoolCfg,Repeatable,DEFAULT_FAILOVER_CAP,DEFAULT_FAILOVER_DEADLINE_SECS,MAX_FAILOVER_DEADLINE_SECSmove verbatim frombusbar-kernel/src/failover/mod.rsintoconfig/pools.rs, besideFailoverCfg.failover/is left with only the walk machinery. Its only callers are busbar-a2a (P3 FLIP-A2A: the a2a plane served through its door; busbar-a2a deleted (stacked on #778) #787) and busbar-llm (row 155 C), so the directory deletes whole with them. Apub usekeeps the historicalfailover::path for rootserve.rsand the legacy crates, whose files are held by open PRs.config::poolsdirectly. config/mod.rs edits are import paths only (agreed with the kernel-neutrality lane).failover/mod.rsfrom its source list. Types are fingerprinted by name andconfig/pools.rsis tracked through the grammar directory, so the snapshot is unchanged.APPLICATION_JSONfrombusbar_contract::protocol, its defining home, not throughbusbar_kernel::proxy(K2). core-adminsrc/tests/tests.rsis held by row 88: busbar-core-admin tests drop the busbar-export-prometheus dev-dep (ship twin: cleanliness -> export) #917, so it is left alone.The move is inside one crate, so no ceiling changes. Behaviour is unchanged.