Repository navigation
KN-2b: the migration's export and hook-transport words are the root legacy table's rows (Law 0) - #976
Merged
Merged
Conversation
…legacy table's rows (KN-2b, Law 0) `--migrate-config`, boot's 1.x refusal and the unknown-field hints spelled the 1.5.3 observability lift-out's sinks (otlp, request-log-webhook, prometheus) and the 1.x hook registry's URL transport (webhook) in kernel source: config/migrate.rs, config/migrate_export.rs and the RETIRED_OBSERVABILITY_KEYS / RETIRED_CONFIG_KEYS_1_5_3 tables in config/mod.rs. BUSBAR-1.6.0.md section 2 puts migrations for plugins that are not in the build in the root legacy table; l.104-120 (Law 0) lets no kernel source name a plugin. Eight frozen rows join plugins.yaml `legacy:` (rendered into crates/busbar/Cargo.toml and the kernel's test stand-in), each citing the v1.5.5 line it is verbatim from: hook_1x_url_transport, metrics_type_key, observability_home, observability_log_change, observability_log_keys, observability_log_type_key, observability_trace_key, observability_trace_key_1_4. The two tables become functions over those rows (retired_config_keys_1_5_3, retired_observability_keys); legacy::pairs reads a `a:b | c:d` row. Output is byte-identical to 1.5.5. RED/pins: - qa/c1-literals.toml strikes seven rows (migrate.rs otlp/prometheus/webhook, migrate_export.rs otlp, config/mod.rs otlp/prometheus/webhook): the gate is red if a literal comes back. - qa/kind-isolation.toml: busbar-kernel export 28 -> 20, instance:export 67 -> 61 (measured). - crates/busbar/src/root/tests/legacy.rs the_observability_lift_out_meets_its_1_5_5_bytes holds the change lines, TODO, rewritten document, boot refusal markers and unknown-field hints to testing/shadow-oracle/fixtures/migrate-observability-1.5.5.yaml, each line cited to v1.5.5.
… not hand-written testing/shadow-oracle/fixtures/migrate-observability-1.5.5.yaml now carries the verbatim stdout/stderr of busbar-aarch64-apple-darwin v1.5.5 (binary sha256 48e2800c..., archive 93f8f02a..., both pinned in golden-digests.tsv) for `--migrate-config`, `--validate` on the 1.x config, and `--validate` on five configs that reach the unknown-field hints; the header names the digest and the commands. The root test reads the change lines, TODO, migrated document, boot-refusal markers and hints out of that output instead of a hand list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kernel neutrality, Law 0 (BUSBAR-1.6.0.md l.104-120; section 2 root legacy table).
--migrate-config, boot's 1.x refusal and the unknown-field hints spelled the 1.5.3 observability lift-out's sinks (otlp, request-log-webhook, prometheus) and the 1.x hook registry's URL transport (webhook) in kernel source:config/migrate.rs,config/migrate_export.rs, andRETIRED_OBSERVABILITY_KEYS/RETIRED_CONFIG_KEYS_1_5_3inconfig/mod.rs.Change
plugins.yamllegacy:(rendered intocrates/busbar/Cargo.toml[package.metadata.busbar.legacy]and the kernel test stand-infrozen_customer_text.yaml), each citing its v1.5.5 source line:hook_1x_url_transport,metrics_type_key,observability_home,observability_log_change,observability_log_keys,observability_log_type_key,observability_trace_key,observability_trace_key_1_4.retired_config_keys_1_5_3()/retired_observability_keys()over those rows;legacy::pairsreads ana:b | c:drow.RED / pins
qa/c1-literals.toml: seven rows struck (migrate.rs otlp/prometheus/webhook, migrate_export.rs otlp, config/mod.rs otlp/prometheus/webhook); the gate reds if a literal returns.qa/kind-isolation.toml: busbar-kernelexport28 -> 20,instance:export67 -> 61 (measured).crates/busbar/src/root/tests/legacy.rsthe_observability_lift_out_meets_its_1_5_5_bytes: change lines, TODO, rewritten document, boot-refusal markers and unknown-field hints held totesting/shadow-oracle/fixtures/migrate-observability-1.5.5.yaml, every line cited to v1.5.5.Overlaps (rule 20, disjoint hunks):
config/mod.rswith #937 / #933;plugins.yamlwith #940; ledger rows with #947 (rule 13 on merge).