Repository navigation
row 88: busbar-core-admin tests drop the busbar-export-prometheus dev-dep (ship twin: cleanliness -> export) - #917
Merged
Conversation
…he named-map scope test resolves `module: prometheus` on the kernel's scrape double
kind-isolation-ship's `test-deps` row reads `cleanliness -> export busbar-core-admin ->
busbar-export-prometheus is not-allowed`: the one standing ship edge no legacy-crate deletion
drains. Its only use was `linked_export_axis()`, which registered the real sink's door so one
named-map test (test_admin_v1_named_map_rejects_an_under_scoped_caller) could configure
`module: prometheus`. The kernel's stand-in export axis (`install_export_axis`) already answers
that module word with its scrape double (R-FIX3: a cleanliness crate's tests use the kernel's
in-crate doubles; the real sink's proofs live with the composition root, which links it).
- crates/busbar-core-admin/src/tests/tests.rs: linked_export_axis installs the kernel's stand-in axis.
- crates/busbar-core-admin/Cargo.toml, Cargo.lock: the dev-dependency is deleted.
- qa/kind-isolation.toml: the `busbar-core-admin -> busbar-export-prometheus` test row is struck;
its drain clause ("the named-map tests resolve the export axis through a contract-only row, and
the dev-dependency is deleted") is what this commit does. No row added, no ceiling moved.
Same change as draft #571 without its #570 merge history (#570 landed); #571 conflicts with
predev on this one row.
…1, the count ModernCI measured once the admin tests stopped depending on the prometheus sink (drain only, Law 9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 88 (
cargo xtask gate --allgreen, judged absolute on the predev→dev move). Drains one standing ship-twin finding:kind-isolation:test-deps—cleanliness -> export busbar-core-admin -> busbar-export-prometheus is not-allowed(standing on every predev move, e.g. #855's gates log).This is the one standing
test-depsedge that no legacy-crate deletion (#787 a2a, #503 voice, row 155 llm) removes.Change
crates/busbar-core-admin/src/tests/tests.rs:linked_export_axis()installs the kernel's stand-in export axis (busbar_kernel::test_support::export_axis::install_export_axis). Its scrape double answersmodule: prometheusas a linked, first-party, one-instance scrape sink. Before, it registered the real sink's door. Only one test uses it:test_admin_v1_named_map_rejects_an_under_scoped_caller.crates/busbar-core-admin/Cargo.toml,Cargo.lock: the dev-dependency is deleted.qa/kind-isolation.toml: thebusbar-core-admin -> busbar-export-prometheus[[dep]]test row is struck. This commit does what the row's owndrainclause says. No row is added and no ceiling moves.This is the same fix as draft #571, without #571's merge history from #570 (#570 has landed). #571 conflicts with predev on exactly this ledger row and can be closed once this lands.
Not a
$change.