Skip to content

fix(tests): stop the crypto-earnings tests expiring 30 days after they were written #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeiserX merged 1 commit into from
Sep 2, 2026
Merged

fix(tests): stop the crypto-earnings tests expiring 30 days after they were written #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions tests/test_currency_correctness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from __future__ import annotations

from datetime import UTC, datetime, timedelta
from pathlib import Path
from unittest.mock import AsyncMock, MagicMock, patch

Expand All @@ -15,6 +16,19 @@
ROOT = Path(__file__).resolve().parents[1]


def _day(n: int) -> str:
"""An ISO date n days ago on the UTC clock get_daily_earnings reads.

The rows below were pinned to 1 and 2 August 2026, and get_daily_earnings
only looks back 30 days. On 1 September the control test stopped seeing its
own rows and went red on main with nothing merged, while its two siblings
kept passing on 0.0 == 0.0 without touching the code they name. Dating the
rows relative to today keeps them inside the window for good, the way
test_power.py already does.
"""
return (datetime.now(UTC) - timedelta(days=n)).strftime("%Y-%m-%d")


@pytest.fixture(autouse=True)
def _isolate_fiat_rates():
"""Save and restore exchange_rates._fiat_rates around every test here.
Expand Down Expand Up @@ -78,8 +92,8 @@ async def test_a_price_move_with_no_new_tokens_earns_nothing(self, tmp_path):
"""The exact fabrication: identical token count, higher price."""
total = await self._daily(
[
("2026-08-01", 1000.0, "ANYONE", 0.10),
("2026-08-02", 1000.0, "ANYONE", 0.12),
(_day(2), 1000.0, "ANYONE", 0.10),
(_day(1), 1000.0, "ANYONE", 0.12),
],
tmp_path,
)
Expand All @@ -90,8 +104,8 @@ async def test_real_new_tokens_are_counted(self, tmp_path):
"""The control: without this the test above passes with earnings broken."""
total = await self._daily(
[
("2026-08-01", 1000.0, "ANYONE", 0.10),
("2026-08-02", 1100.0, "ANYONE", 0.10),
(_day(2), 1000.0, "ANYONE", 0.10),
(_day(1), 1100.0, "ANYONE", 0.10),
],
tmp_path,
)
Expand All @@ -108,8 +122,8 @@ async def test_the_switch_from_usd_to_native_is_not_counted_as_a_gain(self, tmp_
"""
total = await self._daily(
[
("2026-08-01", 100.0, "USD", 1.0),
("2026-08-02", 1000.0, "ANYONE", 0.10),
(_day(2), 100.0, "USD", 1.0),
(_day(1), 1000.0, "ANYONE", 0.10),
],
tmp_path,
)
Expand Down
Loading