fix(tests): stop the crypto-earnings tests expiring 30 days after they were written - #357
Conversation
…y were written The rows in test_currency_correctness.py were pinned to 1 and 2 August 2026 and read back through get_daily_earnings(days=30), which windows on today. From 1 September the control test got 0.0 instead of 10.0 and main went red with nothing merged, while its two 0.0 siblings passed vacuously. Date the rows relative to today, as test_power.py already does.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe currency correctness tests now derive seeded row dates from the current UTC date. The tests remain within the 30-day lookback window used by ChangesCurrency correctness tests
Merge Risk: ⚪ Minimal · up to This test-only change keeps seeded earnings data inside the existing 30-day window without changing application behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependabot's #356 could not merge. Its required
testcheck was red and a rerun stayed red, though it only bumps two workflow pins. The failure is on main itself, and it began on 1 September with nothing merged.tests/test_currency_correctness.pyseeded its earnings rows on the fixed dates 1 and 2 August 2026 and then read them back throughget_daily_earnings(days=30), which windows on today's date. On 31 August the rows were still inside the window and the file passed. On 1 September they fell out, the control testtest_real_new_tokens_are_countedgot 0.0 instead of 10.0, and its two siblings that assert 0.0 kept passing without exercising anything.This dates the rows relative to today, the way test_power.py already does. Nothing under
app/changes, so this does not cut a release. Once it is on main,@dependabot rebaseon #356 gets its check green.Summary by CodeRabbit