Skip to content

Remove Thousands Separators From CANdo Numeric Values #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coderask wants to merge 1 commit into from
Open

Remove Thousands Separators From CANdo Numeric Values #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Autogen/CAN/Doc/GRCAN.CANdo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ Message ID:
data type: u32
units: ms
scaled min: 0
scaled max: 4,294,967,296
scaled max: 4294967296
map equation: "1x"
ECU Status 1:
MSG ID: 0x003
Expand Down
3 changes: 1 addition & 2 deletions Autogen/CAN/Src/DBCparser.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# (which equals the corresponding "Bus ID:" name).
#
# Per-file DBC validity is enforced by:
# - numeric ranges stripped of thousands separators (no commas in numbers)
# - numeric ranges use plain integers (no thousands separators)
# - identifiers normalized to [A-Za-z_][A-Za-z0-9_]* (leading digits prefixed)
# - identifier length capped at 32 chars; long message names dedup leading
# tokens that already appear in the sender, and any composed name still
Expand Down Expand Up @@ -572,7 +572,6 @@ sub _to_number {
my ($v) = @_;
if ( !defined $v ) { return 0; }
$v =~ s/["'\s]//gsmx;
$v =~ s/,//gsmx;
if ( $v !~ /^-?\d/smx ) { return 0; }
return ( $v + 0 );
}
Expand Down
Loading