Remove Thousands Separators From CANdo Numeric Values - #551
Open
coderask wants to merge 1 commit into
Open
Conversation
coderask
force-pushed
the
remove-thousands-separators
branch
from
August 29, 2026 17:36
37c11e3 to
d573839
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Pingmessage'sTimestampfield inGRCAN.CANdohad ascaled maxvalue written as4,294,967,296with commas as thousands separators. YAML parsers read this as the string'4,294,967,296'instead of the integer4294967296, because commas are not part of YAML's numeric syntax.Changes
Autogen/CAN/Doc/GRCAN.CANdo: Removed commas from the only thousands-separated number in the file (scaled max: 4,294,967,296toscaled max: 4294967296).Autogen/CAN/Src/DBCparser.pl: Removed the comma-stripping regex ($v =~ s/,//gsmx;) from the_to_numberfunction, since no CANdo values contain commas anymore. Updated the header comment to reflect the new invariant (plain integers, no thousands separators).Verification
grep -c ',[0-9]{3}' Autogen/CAN/Doc/GRCAN.CANdoconfirms this was the only occurrence.perl -c DBCparser.plpasses.