Skip to content

feat(minecraft-java): stage JVM options for the next start - #66

Open
Baylem wants to merge 1 commit into
GameplanePanel:mainfrom
Baylem:feat/65-minecraft-jvm-startup
Open

Baylem wants to merge 1 commit into
GameplanePanel:mainfrom
Baylem:feat/65-minecraft-jvm-startup

Conversation

@Baylem

@Baylem Baylem commented Nov 12, 2026

Copy link
Copy Markdown
Member

Closes #65. Requires the Gameplane config-field contract tracked in GameplanePanel/Gameplane#938.

Minecraft Java 2.12.0 keeps the independent 75% heap defaults and adds JVM_OPTS, JVM_XX_OPTS and the image's Aikar switch. All five settings apply at the next container start once a server adopts the template. The module README covers the possible initial restart, the 4Gi/2G case and the new settings.

Release order

Ship the supporting Gameplane CRD and operator first. The manifest sets 0.4.1 as the minimum compatible release. If support first ships in a later release, set that version here before publishing. After merging this change, update the Gameplane modules submodule to the merged commit and publish the signed 2.12.0 bundle through the module release workflow. Existing installations can retain 2.11.0 until ready to adopt.

Verification

  • python test-minecraft-jvm.py ran the pinned Java 21 image's launcher in three disposable containers. Its final argument lists included the independently sized default heaps, percentage modes, custom options and the native preset only when enabled.
  • gp-module validate minecraft-java and the module locale check passed.
  • python validate.py minecraft-java found no errors. It reported the existing /data working-directory and HOME advisories for the four pinned images.

Signed-off-by: Baylem <zelathis@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b5444b17-fc5c-4285-b0ac-275b5b0d9575
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Baylem Baylem left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the 2.12.0 catalog fields, version gate, and upgrade instructions against the pinned Java 21 launcher. The image tests exercised separately resolved initial and maximum heap, mixed percentage and fixed sizes, both option variables, and the native Aikar preset. Catalog validation and the devcontainer checks passed.

Release the compatible Gameplane CRDs and operator before publishing this catalog version. Confirm that the minimum version identifies a release containing deferred environment support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Minecraft Java startup flags and deferred heap settings in the catalog

1 participant