Repository navigation
Conversation
Signed-off-by: Baylem <zelathis@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Signed-off-by: Baylem <zelathis@gmail.com>
CI Report - 6b2e373run 43163065380 - attempt 1 0 failed - 0 passed - 0 skipped - 33 cancelled - 2m18s elapsed Test selection: unknown - per-suite table Coverageno coverage/* commit statuses found on 6b2e373 Changed
Slowest jobs
e2e buckets run
|
Signed-off-by: Baylem <zelathis@gmail.com>
Baylem
left a comment
Baylem
left a comment
There was a problem hiding this comment.
The full previous-release upgrade suite passed on this commit in a fresh Kind cluster, starting from published Gameplane 0.3.0. It exercised template adoption, then staged an edit and a clear. The running pod kept its UID, pod template and environment after each save. Each explicit restart loaded the expected value. Database migrations, retained data and the final reinstall with stale CRDs also passed.
Reviewed preview behavior against the pinned launcher. The dashboard detects a 3072M automatic initial heap above a 2G maximum on a 4 GiB server, resolves the MEMORY fallback for a partial schema, and suppresses image-specific flags for an overridden entrypoint. The next-start notice checks the running revision. Both settings suites passed all 50 tests. The Pencil exports cover valid settings and the invalid automatic-heap state.
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Closes #938. Companion catalog change: GameplanePanel/module#66.
Startup settings
A template can mark an environment field with
applyOnRestart: true. The operator installs a stable optional Secret reference for that field and stages its resolved value in the GameServer-owned Secret. Editing or clearing that field leaves the running Pod's environment and template intact. Ordinary settings retain their rollout behavior. Files interpolating a staged field are copied by the existing init container on the next Pod start. Adopting the template on an existing server can restart it once.Settings reads the server's admitted template, including when a newer catalog revision is pending. The Minecraft Java startup group exposes the options declared by that schema. For the itzg image, it shows the independently resolved heap arguments, including percentage modes, and checks the initial heap against the maximum. On a 4Gi server with a 75% automatic initial heap and a 2G maximum, the preview shows 3072M and blocks the invalid save. The restart notice follows the edited fields and distinguishes initial adoption.
Verification
Catalog delivery
Ship the CRD and operator before publishing Minecraft Java 2.12.0. When the module change has merged, advance the catalog submodule to the merged revision and publish the signed bundle through the release or republish workflow. Existing OnRequest servers can schedule their template adoption.