Skip to content

fix(web): allow stopping a provisioning server from its detail page - #940

Open
Baylem wants to merge 3 commits into
masterfrom
fix/web-stop-during-startup
Open

Baylem wants to merge 3 commits into
masterfrom
fix/web-stop-during-startup

Conversation

@Baylem

@Baylem Baylem commented Nov 12, 2026

Copy link
Copy Markdown
Member

Enable Stop in the detail header and Overview while a server is Pending or Starting. Both controls use the existing scoped lifecycle request and keep their permission and in-flight checks.

Verified both phases from the header, Overview, and fleet list. The header tests also assert that exactly one request reaches the selected remote cluster and namespace. Includes an unreleased changelog entry.

Closes #932.

@Baylem
Baylem requested a review from ValgulNecron as a code owner November 12, 2026 05:05
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e3826d8 and 4b28d0a.

Files ignored due to path filters: 2

  • assets/design-export/screenshots/o4LH8W.png is excluded by !**/*.png
  • design.pen is excluded by !**/*.pen
Files selected for processing: 11

  • assets/design-export/MANIFEST.md
  • assets/design-export/json/o4LH8W.json
  • changelog/unreleased/932-stop-during-startup.md
  • web/e2e/screenshots/slice2a.spec.ts
  • web/specs.md
  • web/src/components/server/ServerActionsCard.test.tsx
  • web/src/components/server/ServerActionsCard.tsx
  • web/src/routes/ServerDetail.test.tsx
  • web/src/routes/ServerDetail.tsx
  • web/src/routes/Servers.test.tsx
  • web/src/test/handlers.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Signed-off-by: Baylem <zelathis@gmail.com>

@Baylem Baylem left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the header, Overview card, and fleet lifecycle controls. Pending and Starting both allow Stop. The header sends one request to the selected cluster and namespace. Target permissions and the in-flight guard still apply. All 119 tests across the three affected suites passed, and all three added dashboard statement lines were covered. The Pencil provisioning state shows the enabled controls.

@Baylem Baylem self-assigned this Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

CI Report - 4b28d0a

run 43165023606 - attempt 1

0 failed - 11 passed - 22 skipped - 64m11s elapsed

Test selection: partial - per-suite table

Coverage

Module Measured Gate Margin
web L94.07 S92.18 B86.53 F90.29 L92 S92 B82 F76 +0.18

Changed

Area Files +/-
assets/ 3 +89/-509
(root) 1 +87/-510
web/ 8 +57/-13
changelog/ 1 +3/-0

Slowest jobs

Job Duration
build e2e images 15m59s
build e2e images (arm64) 11m47s
e2e web live / arm64 (kind) 10m37s
e2e web live / amd64 (kind) 9m49s
web 6m43s

e2e buckets run

multicluster, upgrade

Signed-off-by: Baylem <zelathis@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow a server to be stopped from its detail page during startup

1 participant