Skip to content

fix(web): allow stopping a provisioning server - #939

Closed
Baylem wants to merge 1 commit into
masterfrom
fix/stop-during-provisioning
Closed

Baylem wants to merge 1 commit into
masterfrom
fix/stop-during-provisioning

Conversation

@Baylem

@Baylem Baylem commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Superseded by #940.

@Baylem
Baylem requested a review from ValgulNecron as a code owner November 12, 2026 05:03
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The detail header and Overview card now allow operators with control access to stop servers in Pending or Starting. Tests cover both phases, stop-request scope, and the enabled fleet-row action.

Changes

Startup stop controls

Layer / File(s) Summary
Enable Stop in provisioning phases
web/src/routes/ServerDetail.tsx, web/src/components/server/ServerActionsCard.tsx, web/src/routes/ServerDetail.test.tsx, web/src/components/server/ServerActionsCard.test.tsx, web/src/routes/Servers.test.tsx, web/specs.md, changelog/unreleased/932-stop-during-startup.md
The detail header and Overview card enable Stop during Pending and Starting when the user has control access and no lifecycle mutation is pending. Tests cover the stop request scope and fleet-row action. The specification and changelog describe the updated behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature · Severity of issue fixed: Medium

Suggested labels: type: feature, area: web

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Baylem Baylem changed the title Allow Stop while a game server is provisioning fix(web): allow stopping a provisioning server Nov 12, 2026
@Baylem Baylem closed this Nov 12, 2026
@github-actions

Copy link
Copy Markdown

CI Report - b748309

run 43158780373 - attempt 1

0 failed - 11 passed - 22 skipped - 41m24s elapsed

Test selection: partial - per-suite table

Coverage

no coverage/* commit statuses found on b748309

Changed

Area Files +/-
web/ 6 +40/-12
changelog/ 1 +3/-0

Slowest jobs

Job Duration
build e2e images 15m14s
e2e web live / amd64 (kind) 12m0s
e2e web live / arm64 (kind) 11m33s
build e2e images (arm64) 10m27s
web e2e (mock) 6m55s

e2e buckets run

multicluster, upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant