fix(aria_uploader): metadata.embodiment = robot config, not the 'aria' device - #529
Draft
ElmoPA wants to merge 1 commit into
Draft
fix(aria_uploader): metadata.embodiment = robot config, not the 'aria' device#529ElmoPA wants to merge 1 commit into
ElmoPA wants to merge 1 commit into
Conversation
…' device aria_uploader hardcoded embodiment='aria', so every aria recording landed in SQL with embodiment='aria' instead of the robot config (human_bimanual/left/ right) the operator intended. Their typed value went to the now-deprecated robot_name field and was dropped by add_raw_data_to_table (reads metadata['embodiment']). Decouple the capture DEVICE (drives the raw_v2/<device>/ bucket layout) from the EMBODIMENT (metadata -> SQL embodiment column): Uploader gains a 'device' param that defaults to embodiment (eva/eve unchanged), and aria_uploader passes device='aria' with embodiment defaulting to human_bimanual (override via --embodiment for left/right arm). aria raw path stays raw_v2/aria/. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aria_uploader hardcoded embodiment='aria', so every aria recording landed in
SQL with embodiment='aria' instead of the robot config (human_bimanual/left/
right) the operator intended. Their typed value went to the now-deprecated
robot_name field and was dropped by add_raw_data_to_table (reads
metadata['embodiment']).
Decouple the capture DEVICE (drives the raw_v2// bucket layout) from the
EMBODIMENT (metadata -> SQL embodiment column): Uploader gains a 'device' param
that defaults to embodiment (eva/eve unchanged), and aria_uploader passes
device='aria' with embodiment defaulting to human_bimanual (override via
--embodiment for left/right arm). aria raw path stays raw_v2/aria/.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com