You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes passing of settings from the old data state to a new one. Among other things, it fixes the point line in a more systematic way than #378 . It also fixes passing of mesh attributes as mentioned in #383 .
🤖 Suggestions from an AI review. Feel free to ignore if not relevant.
A pointline command followed immediately by new solution data can lose the line: CloneEmpty() can copy the old coordinates before the queued POINT_LINE command executes. The wait in NewMeshAndSolution() happens after that copy. Could we preserve point coordinates on the main thread when applying the update, as in Retain point line when new data is sent #378, and avoid copying the live point-coordinate vector from the communication thread?
There may also be a data race: the worker’s CloneEmpty() copies point_coords while the main thread can replace that vector when executing POINT_LINE or installing new data. Could we avoid reading the live vector from the worker, or synchronize those accesses? Copying the coordinates again on the main thread would fix the stale-value issue but leave this concurrent access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes passing of settings from the old data state to a new one. Among other things, it fixes the point line in a more systematic way than #378 . It also fixes passing of mesh attributes as mentioned in #383 .