[v-dobrev]

Similar to the mesh command, it captures reference nodes on the first load and visualizes displacement on subsequent pmesh loads.

[tzanio]

🤖 Suggestions from an AI review. Feel free to ignore if not relevant.

• This introduces an issue where pmesh loses -a on updates after initialization because ExecuteScriptCommand() creates a default new_state with keep_attr=false. This predates the PR, but the new parallel loader uses it to replace material attributes with processor ranks; serial mesh preserves them.

• To fix, preserve the session setting immediately before calling ScriptReadDisplMesh():

  new_state.keep_attr = win.data_state.keep_attr;

[v-dobrev]

Regarding the AI suggestion: it may be best to construct the new_state here:

glvis/lib/script_controller.cpp

Line 456 in 4b9df8f

DataState new_state;

using win.data_state.Clone():

            DataState new_state = win.data_state.CloneEmpty();

instead of the default constructor. This, in particular, will copy the keep_attr field.

@najlkin, does this sound good to you?

[najlkin]

Yeah, that sounds good 👍 . I introduced the method just recently for exactly such cases, so the solution itself is not copied, but the settings are. Probably we will not need #378 then, but I need to check more closely 🤔 .

[v-dobrev]

Yeah, that sounds good 👍 .

Okay, done.

[najlkin]

This one should be also cloned to preserve all settings (current or future). I opened a new PR fixing all occurrences #384 😉 .

[v-dobrev]

Since you fixed it in the other PR, do you still want me to fix it here?