Repository navigation
[BUG] Guarded dereferencing of window and scene pointers - #381
Merged
Merged
Conversation
Contributor
Author
|
Ahh, CI is broken because of:
#if defined(__cplusplus)
#else
typedef HYPRE_Int bool;
#define true 1
#define false 0
#endif |
tzanio
approved these changes
Oct 22, 2026
This was referenced Oct 22, 2026
Merged
Contributor
Author
|
ping @camierjs |
camierjs
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current horrible design of
aux_vis.cpp🤢 assumes thatwndandlocscenepointers are set before any global functions are called. For example, this is not true in glvis live, where the page calls resizing before initialization of the wasm canvas is finished leading to dereferencing of null as reported in GLVis/web#26 . Only reasonable occurrences are fixed here. Much better design would be a window object as proposed in #170 .