Repository navigation
Fix hypre bool - #18
Merged
Merged
Conversation
61 tasks
v-dobrev
approved these changes
Oct 23, 2026
pazner
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transition between ubuntu-24.04 and ubuntu-26.04 introduces gcc with default C23 standard, which has a native bool type colliding with the hypre definition (see GLVis/glvis#381 (comment)). The custom hypre definition is removed in later versions of hypre, but unless we want to upgrade hypre, the standard must be pinned to something lower than C23 🤔 .