Skip to content

Fix coverage-baseline failure by removing manifest record overlap with fwl-io shared datasets - #966

Closed
EmmaPostolec with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-upload-unit-coverage-job
Closed

EmmaPostolec with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-upload-unit-coverage-job

Conversation

Copilot AI commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Description

The Upload unit coverage for main job was failing after coverage upload because unit tests failed on a manifest contract: two Zenodo records were declared in both PROTEUS and the fwl-io shared manifest. This change removes the overlap and aligns dataset keys/tests with shared-manifest ownership.

  • Manifest ownership cleanup

    • Removed duplicate PROTEUS-owned entries for:
      • Zeng 2019 mass-radius (10.5281/zenodo.15727899)
      • Seager 2007 EOS (10.5281/zenodo.15727998)
    • Deleted corresponding local registry files that should not exist for shared datasets.
  • Shared key alignment

    • Updated dataset constants to shared-manifest keys:
      • MASS_RADIUS_ZENG_2019 = "interior.mass_radius.zeng_2019"
      • EOS_SEAGER_2007 = "interior.eos.seager_2007"
  • Test contract updates

    • Updated manifest ownership expectations and shared-dataset mapping in tests/data/test_manifest.py.
    • Updated key assertions in downstream tests (tests/utils/test_data.py, tests/plot/test_cpl_population.py).

Example of the key correction:

# src/proteus/data/__init__.py
MASS_RADIUS_ZENG_2019 = "interior.mass_radius.zeng_2019"
EOS_SEAGER_2007 = "interior.eos.seager_2007"

Include screenshots or log files if appropriate.

Validation of changes

  • Inspected failing run/job logs and confirmed failure source was test_no_record_is_declared_in_both_manifests (not Codecov upload).
  • Verified the PROTEUS manifest and shared manifest no longer intersect on Zenodo records.
  • Verified the moved datasets resolve via shared-manifest keys/subdirs and pinned records.

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

Copilot AI and others added 2 commits October 7, 2026 08:26
Co-authored-by: EmmaPostolec <122358811+EmmaPostolec@users.noreply.github.com>
Co-authored-by: EmmaPostolec <122358811+EmmaPostolec@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'Upload unit coverage for main' Fix coverage-baseline failure by removing manifest record overlap with fwl-io shared datasets Oct 7, 2026
Copilot AI requested a review from EmmaPostolec October 7, 2026 08:30
@EmmaPostolec
EmmaPostolec marked this pull request as ready for review October 7, 2026 08:30
@EmmaPostolec
EmmaPostolec requested a review from a team as a code owner October 7, 2026 08:30

@EmmaPostolec EmmaPostolec left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #937 into main, the unit coverage for main job failed. I asked copilot to fix the test so main can pass all the tests and be green again.

@timlichtenberg it would be nice if you have time for a quick review of this since you are the author of the last two PR (#960 and #961) before #937 so you may be more familiar with this part of the code.

I realized now that this PR is a duplicate of #964 ?

@timlichtenberg

Copy link
Copy Markdown
Member

Closing as a duplicate of #964, which made the same change (Seager and Zeng read from the fwl-io shared manifest, fwl-io>=26.10.7) and is merged.

@EmmaPostolec
EmmaPostolec deleted the copilot/fix-upload-unit-coverage-job branch October 7, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants