Repository navigation
Fix coverage-baseline failure by removing manifest record overlap with fwl-io shared datasets - #966
Closed
EmmaPostolec with Copilot wants to merge 3 commits into
Closed
EmmaPostolec with Copilot wants to merge 3 commits into
EmmaPostolec with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: EmmaPostolec <122358811+EmmaPostolec@users.noreply.github.com>
Co-authored-by: EmmaPostolec <122358811+EmmaPostolec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'Upload unit coverage for main'
Fix coverage-baseline failure by removing manifest record overlap with fwl-io shared datasets
Oct 7, 2026
EmmaPostolec
marked this pull request as ready for review
October 7, 2026 08:30
EmmaPostolec
reviewed
Oct 7, 2026
Member
There was a problem hiding this comment.
After merging #937 into main, the unit coverage for main job failed. I asked copilot to fix the test so main can pass all the tests and be green again.
@timlichtenberg it would be nice if you have time for a quick review of this since you are the author of the last two PR (#960 and #961) before #937 so you may be more familiar with this part of the code.
I realized now that this PR is a duplicate of #964 ?
Member
|
Closing as a duplicate of #964, which made the same change (Seager and Zeng read from the fwl-io shared manifest, fwl-io>=26.10.7) and is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Upload unit coverage for mainjob was failing after coverage upload because unit tests failed on a manifest contract: two Zenodo records were declared in both PROTEUS and thefwl-ioshared manifest. This change removes the overlap and aligns dataset keys/tests with shared-manifest ownership.Manifest ownership cleanup
10.5281/zenodo.15727899)10.5281/zenodo.15727998)Shared key alignment
MASS_RADIUS_ZENG_2019 = "interior.mass_radius.zeng_2019"EOS_SEAGER_2007 = "interior.eos.seager_2007"Test contract updates
tests/data/test_manifest.py.tests/utils/test_data.py,tests/plot/test_cpl_population.py).Example of the key correction:
Include screenshots or log files if appropriate.
Validation of changes
test_no_record_is_declared_in_both_manifests(not Codecov upload).Checklist