Repository navigation
Stop Windows CI failing on slow durable writes - #18
Merged
Merged
Conversation
Durable writes on the runner's system drive are slow enough to trip the tests' 1 s and 5 s budgets, which failed a different test on most runs. TEMP and TMP now point at the runner's temp directory on the workspace drive. The MAX_PATH test assumed a long temporary root, so it now builds a path past the limit whatever the root's length.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Windows CI failed a different test on most recent
mainruns, each time on a durable-write or retirement deadline. Tests now keep their temporary files on the runner's workspace drive, where durable writes are about 10 to 40 times faster, so they stop using up their budgets. No test budget or production deadline changes.Evidence
f12ebe9failedcheck (windows-latest)on two attempts with different tests, the second withAtomic publication deadline reached.a5ff8bealso failed on a different Windows test.After: with temporary files on
D:, 3 of 3 Windows jobs had no timing failure. Their only failure was the path test fixed here.C:and 0.22 to 0.56 ms onD:; p99 24 to 27 ms onC:and 0.7 to 1.3 ms onD:.cargo clippy --all-targets --locked -- -D warningsandcargo fmt --checkpass.Merge danger
Door: two-way. Blast radius: CI
Windows CI no longer exercises durable writes on the system drive. Local runs still do.
Unverified
C:had a 5.4 ms p99 on the probe.a5ff8be(Target disposition deadline reached, a 3 s test deadline) is not addressed.