Repository navigation
Stop two tests failing on machines without Chrome - #19
Merged
Merged
Conversation
bridge doctor and MCP browser admission both refuse when the host has no Chrome, so these tests failed on any machine without it. Give them a stand-in executable through CHROME_PATH; their assertions do not change.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Two tests failed on any machine without Chrome because they relied on the host's Chrome without saying so. They now get a stand-in executable through
CHROME_PATH, so they give the same result on every host. No assertion or production code changes.The failures were correct production behaviour: bridge doctor exits 1 without Chrome, and MCP refuses a browser consult before creating a session. The no-Chrome refusal keeps its own test in
tests/mcp_service_parity.rs.Evidence
f12ebe9, Windows without Chrome:bridge_doctor_accepts_and_ignores_verbose_like_commanderfails atplain.status.code()withleft: Some(1) right: Some(0). Doctor printsNo Chrome installation detected.local_browser_cli_and_mcp_admit_foreground_and_detached_rust_workersfails inpublic_sessionwithleft: 0 right: 1.After: both pass.
f12ebe9and on Keep waiting for the answer when a page read stalls after the send #17's head: both tests pass onubuntu-latest. Onwindows-latestthey pass on Keep waiting for the answer when a page read stalls after the send #17's head; onf12ebe9that job stopped at a timing failure in the unit tests before reaching them. This is why only local runs showed the failures.tests/stdio_and_cli.rs.cargo build,cargo clippy --all-targets --locked -- -D warningsandcargo fmt --checkpass.cargo test --locked --no-fail-fast: 923 passed, 0 failed, 15 ignored, on the first commit. The second commit changes only a comment; after it,cargo fmt --checkand the admission test pass.Merge danger
Door: two-way. Blast radius: tests
These tests no longer exercise real Chrome discovery on the host.
src/browser_detect.rshas its own unit tests for discovery order.Unverified