added cmscan process used in rfam pipeline - #43
Dishalodha wants to merge 3 commits into
Conversation
markquintontulloch
left a comment
There was a problem hiding this comment.
Looks good, just a slight query about placement of the version reporting logic
|
thanks @markquintontulloch, I have seen topic being used in nf-core modules now. I think it is to call the version information from modules and report it in one channel. You can now call the versions with |
|
@Dishalodha sorry, I don't think I was clear. I wasn't questioning the use of a versions topic. I was suggesting that we could do away with the creation of the versions.yml file as an intermediate that's read by the topic definition, and use an eval directly in the definition. That appears to be the approach suggested in the guide you linked to above (in the 'Using eval outputs' section). However, whereas the example in that guide discards So, in the case of this module, I think the versions topic should be defined as: and the |
markquintontulloch
left a comment
There was a problem hiding this comment.
Looks good to me
Adding the cmscan module used in rfam