Repository navigation
fix: what the product screenshots showed (dark theme, no-key answers, note actions) - #83
Merged
Merged
Conversation
… note actions) Taking screenshots for the website and Product Hunt from a fictional demo vault showed: - the ◐ toggle did nothing on the dashboard: app.css resolved its colour aliases on :root, so body.dark changing --cl-* never reached them (checked on main: body stays rgb(255,255,255) with body.dark set); now on body too; - "What did we decide about pricing?" without a key quoted a daily note and a link line, not the decision: words of one family now match (rough stem to four letters), a line inherits the words of its heading and shows it, the title adds a quarter point, and notes are ordered by their best line; - the note view's Key points / Summarize / Action items / Expand were fixed to Spanish for every user: they follow the browser language now, and the API and note_ai default to English; - search results on the notes home use content_snip (words around the match) instead of the few-word excerpt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Screenshots for the website and Product Hunt were taken from a fictional demo vault (a small design studio: projects, meetings, daily notes, reading notes) on a fresh install with no key. Four things a first visitor would see were wrong:
body.darkwas set, the page stayed white.app.cssdeclares its aliases (--bg: var(--cl-bg)…) on:root, where they resolve with the light palette, andbody.darkonly changes--cl-*onbody. Checked onmain: body background staysrgb(255,255,255)after the toggle.:root, body. After the toggle:rgb(15,17,21).## Decision, the line says "Keep both plans and make yearly the default"). "decide" did not match "Decision", and headings were ignored.deci, pricing/price →pric). A line inherits the question words of its heading (full for the first line under it, half after) and is shown as "Decision (2026-10-21) — Keep both plans…". The note's title adds a quarter point per word but never makes a line a candidate alone. Notes are ordered by their best line.data-lang="es": every user got Spanish.note_ai.DEFAULT_LANGdefault to English. Translate buttons unchanged.content_snip, the words around the match.How it was tested
brain.askwith the mock provider on the demo vault: pricing → the decision line first; runway → "Cash: 48,000 €… about 11 months of runway"; Sam → the sync-bug lines from three notes.main.test_brain_no_key.py); note actions follow the browser and search usescontent_snip(test_notes_home_static.py).test_csp_staticunchanged.pytest -m "not live"(offline, headless Chrome): 2126 passed, 22 skipped, 1 failed — the fastembed test that needs the model on disk and fails the same way onmain.Checklist
CHANGELOG.mdentry under Unreleased.🤖 Generated with Claude Code