[EVMCOD]

What and why

The Windows bundles workflow already installed the NSIS setup and started the app, but it only waited for /api/health, then killed the whole process tree with taskkill /T /F (the last run logged The process with PID … could not be terminated). That proves the app starts; it does not prove the two Windows-specific things that were fixed blind in #75: that parent_watch does not end the app, and that closing the app stops its server. And nothing checked the uninstall, although the data folder (%LOCALAPPDATA%\ConductLoop\data) sits inside the per-user install folder.

scripts/windows-smoke.ps1 -Setup <setup.exe> replaces that step:

1. installs the setup silently, per user, and finds conductloop-desktop.exe and conductloop-server.exe;
2. the server answers /api/health within 120 s;
3. /api/platform says windows, with the in-app browser and code execution off (prints the keychain state);
4. first run: onboarding fresh, /welcome served;
5. a ConductLoop window, and a screenshot;
6. 20 s later the app and its server are still running;
7. closing the window (CloseMainWindow) stops the server: port free and no conductloop-server.exe left within 15 s;
8. uninstalling silently removes the app and keeps data\ops.db.

It talks only to 127.0.0.1:7777 with GETs and publishes nothing. The step stays continue-on-error, as decided for it (a runner has no real desktop session), but each failed check is an ::error annotation on the run page, and the screenshot and log are uploaded for 3 days. The workflow is still manual; it was dispatched on this branch to test it.

How it was tested

• tests/test_windows_bundles_workflow.py updated (installer uploads, the smoke step runs the script, its output is kept) and extended (the script only reads the local server, and checks platform, 20 s, close and uninstall); tests/test_workflows_guard.py green.
• No PowerShell on the Mac: the dispatched run of the workflow on this branch (run 41037555981) was the real test. All 8 checks passed on windows-latest, first try: installed per user; server in 10 s as 1.2.3; /api/platform windows with browser and code execution off (keys in the encrypted file, "no system keychain integration on Windows yet"); first run with /welcome; the ConductLoop window open (screenshot: the welcome page renders, new icon in the title bar and taskbar); still running 20 s later; closing the window stopped the server in 1 s; uninstalling removed the app and kept data\ops.db.
• Seen, not changed here: the welcome page says the key "is stored in the Keychain of this Mac" on Windows (and Linux) too.

Checklist

• Tests added or updated.
• No migrations.
• CHANGELOG.md entry under Unreleased.
• No personal data and no secrets.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-30T10:02:41.087220Z	2f89a63	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.