Skip to content

ci(measure): the Compare summary leaves kept IFCs out of its text diff and caps it under GitHub's 1 MiB, the whole diff an artifact #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrunkOnJava merged 2 commits into from
Nov 2, 2026
Merged

ci(measure): the Compare summary leaves kept IFCs out of its text diff and caps it under GitHub's 1 MiB, the whole diff an artifact #1250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7accc2
ci(measure): the Compare summary leaves kept IFCs out of its text dif…
DrunkOnJava Nov 2, 2026
82b4fba
Merge branch 'main' into ci/measure-summary-cap
DrunkOnJava Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions .github/workflows/measure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,13 +423,37 @@ jobs:
echo
echo "### Scorer differences (base → head)"
echo
# The kept IFCs and GLBs are compared by hash above; diffed as
# text they made a 3 GB summary GitHub refused (run
# 41537426493). The whole diff is the compare-scorer-diff
# artifact; the summary shows its start, under GitHub's 1 MiB.
diff -r -U0 -x commit.txt -x runner.txt -x '*.log' -x ifc.sha256 -x diagnostics.json \
-x '*.ifc' -x '*.glb' measure-base measure-head > scorer-diff.txt || true
limit=$((640 * 1024))
size=$(stat -c %s scorer-diff.txt)
echo '```diff'
diff -r -U0 -x commit.txt -x runner.txt -x '*.log' -x ifc.sha256 -x diagnostics.json measure-base measure-head || true
head -c "$limit" scorer-diff.txt
echo
echo '```'
if [ "$size" -gt "$limit" ]; then
echo
echo "**Truncated:** the scorer diff is $size bytes and this shows its first $limit; the whole diff is the \`compare-scorer-diff\` artifact."
fi
else
echo "No base; the scores are in the measure-head artifact."
fi
} >> "$GITHUB_STEP_SUMMARY"
} > summary.md
size=$(stat -c %s summary.md)
if [ "$size" -gt 1000000 ]; then
echo "::error::the summary is $size bytes, over GitHub's 1 MiB step summary limit"
exit 1
fi
cat summary.md >> "$GITHUB_STEP_SUMMARY"
- uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
if: ${{ hashFiles('scorer-diff.txt') != '' }}
with:
name: compare-scorer-diff
path: scorer-diff.txt

# B81: the base and head jobs above run on different runners, so their wall
# times compare machines as much as code. With `timing`, one runner builds
Expand Down
Loading