Repository navigation
ci(measure): the Compare summary leaves kept IFCs out of its text diff and caps it under GitHub's 1 MiB, the whole diff an artifact - #1250
Merged
Conversation
…f and caps it under GitHub's 1 MiB, the whole diff an artifact
DrunkOnJava
enabled auto-merge (squash)
November 2, 2026 23:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measure's Compare summary no longer diffs the kept IFC and GLB files as text. Those changes are already reported per model through
ifc.sha256. The whole scorer diff is uploaded as thecompare-scorer-diffartifact, and the summary shows its first 640 KiB with an explicit "Truncated" line when it is longer. If the summary would still pass GitHub's 1 MiB limit, the step now fails instead of passing with the summary silently dropped.Motivation
Run 41537426493 (
keep_ifc, v0.6.1 against v0.12.0, #1247) produced a 3.1 GB step summary, becausediff -rread every keptmodel.ifc. GitHub refused it ("supports content up to a size of 1024k"), yet the Compare job reported success, so the run's comparison was never shown.Changes
.github/workflows/measure.yml, Compare:diff -rexcludes*.ifcand*.glband writesscorer-diff.txt;summary.md, checked against 1,000,000 bytes, then appended;compare-scorer-diffwhen a diff exists.Testing
Unit tests are banned in this repository: do not add them. Show the change working end to end on real files instead.
measure.ymlis the only file changed, mode unchanged.keep_ifcon Core Interior and Einhoven: the IFCs are kept in both sides' artifacts, Compare succeeds with no "upload aborted" error, andcompare-scorer-diffis uploaded.Audit-honesty checklist
Legal and contribution hygiene
Breaking changes
None.