Skip to content

ci(measure): the Compare summary leaves kept IFCs out of its text diff and caps it under GitHub's 1 MiB, the whole diff an artifact - #1250

Merged
DrunkOnJava merged 2 commits into
mainfrom
ci/measure-summary-cap
Nov 2, 2026
Merged

DrunkOnJava merged 2 commits into
mainfrom
ci/measure-summary-cap

Conversation

@DrunkOnJava

Copy link
Copy Markdown
Owner

Summary

Measure's Compare summary no longer diffs the kept IFC and GLB files as text. Those changes are already reported per model through ifc.sha256. The whole scorer diff is uploaded as the compare-scorer-diff artifact, and the summary shows its first 640 KiB with an explicit "Truncated" line when it is longer. If the summary would still pass GitHub's 1 MiB limit, the step now fails instead of passing with the summary silently dropped.

Motivation

Run 41537426493 (keep_ifc, v0.6.1 against v0.12.0, #1247) produced a 3.1 GB step summary, because diff -r read every kept model.ifc. GitHub refused it ("supports content up to a size of 1024k"), yet the Compare job reported success, so the run's comparison was never shown.

Changes

  • .github/workflows/measure.yml, Compare:
    • diff -r excludes *.ifc and *.glb and writes scorer-diff.txt;
    • the summary is built in summary.md, checked against 1,000,000 bytes, then appended;
    • a new upload of compare-scorer-diff when a diff exists.

Testing

Unit tests are banned in this repository: do not add them. Show the change working end to end on real files instead.

  • Workflow YAML parses; measure.yml is the only file changed, mode unchanged.
  • Measure 41541701214, from this branch with keep_ifc on Core Interior and Einhoven: the IFCs are kept in both sides' artifacts, Compare succeeds with no "upload aborted" error, and compare-scorer-diff is uploaded.
  • N/A: IFC exporter, performance.

Audit-honesty checklist

  • README / docs reflect the current state after this PR
  • N/A: changelog fragment (CI only)
  • Commit messages describe what changed and why
  • No emojis in code, docs, or commit messages
  • No private paths, personal email addresses, or internal jargon in committed files

Legal and contribution hygiene

  • Apache-2.0
  • No Autodesk proprietary content
  • No fixtures

Breaking changes

None.

…f and caps it under GitHub's 1 MiB, the whole diff an artifact
@DrunkOnJava DrunkOnJava added area:ci Work in the ci area. type:ci Continuous integration or automation work. labels Nov 2, 2026
@DrunkOnJava
DrunkOnJava enabled auto-merge (squash) November 2, 2026 23:05
@DrunkOnJava
DrunkOnJava merged commit daeb207 into main Nov 2, 2026
33 checks passed
@DrunkOnJava
DrunkOnJava deleted the ci/measure-summary-cap branch November 2, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci Work in the ci area. type:ci Continuous integration or automation work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant