Repository navigation
docs(spec-coverage): move the rows the 2026-10-27 main run proves, and say what measured them (#140, #147, #148, #133, #127) - #398
Merged
Conversation
…d say what measured them (#140, #147, #148, #133, #127) Seven rows leave partial for closes because no record of any kind errors on the 52 drawings of run 40532346172 and the errors their notes still quote were fixed: TEXT, ATTRIB, ATTDEF (#258), MTEXT (#261), VIEW (#263, #284), DIMSTYLE (#293) and HATCH (#264, the R14 records routed). §22 AcDb:Template goes from missing to partial: dxf_header reads $MEASUREMENT from it (#320). §9 stays closes, now tracked by #127 (R13) and carrying the per-release evidence behind closing #128, #129 and #130. The page's Last measured line and the paragraph that said closes came from a local 19-file corpus are updated.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 tasks done
DrunkOnJava
added a commit
that referenced
this pull request
Oct 27, 2026
# Conflicts: # docs/data/spec-coverage.tsv # docs/spec-coverage.md
DrunkOnJava
enabled auto-merge (squash)
October 28, 2026 16:43
DrunkOnJava
added a commit
that referenced
this pull request
Oct 28, 2026
…ain run (#195) (#401) * docs(spec-coverage): move the rows the 2026-10-27 main run proves, and say what measured them (#140, #147, #148, #133, #127) Seven rows leave partial for closes because no record of any kind errors on the 52 drawings of run 40532346172 and the errors their notes still quote were fixed: TEXT, ATTRIB, ATTDEF (#258), MTEXT (#261), VIEW (#263, #284), DIMSTYLE (#293) and HATCH (#264, the R14 records routed). §22 AcDb:Template goes from missing to partial: dxf_header reads $MEASUREMENT from it (#320). §9 stays closes, now tracked by #127 (R13) and carrying the per-release evidence behind closing #128, #129 and #130. The page's Last measured line and the paragraph that said closes came from a local 19-file corpus are updated. * docs(criteria): re-measure the 1.0 requirements from the 2026-10-27 main run (#195) Header, R2, R3, R4, R8, X1 and S3 now carry what run 40542129639 (main 61255e9) and docs/data/spec-coverage.tsv say: 52 drawings with 0 errored records and 533 skipped, 53 sections scored by the DXF oracle with 22 values disagreeing, 90 closes, 13 partial, 6 decoder and 29 missing rows, a wasm32 compile of the library in the Clippy job. X1 (DXF) moves from not measured to failed: the HEADER, TABLES, ENTITIES and BLOCKS probes pair the written records with AutoCAD's export and find 0 groups disagreeing, and 342 entity records of 18 kinds and the OBJECTS section are not written. No other status changes. * docs(criteria): R3 counts the rows #398 moves: 97 closes, 7 partial, 6 decoder, 28 missing (#195) The counts are those of docs/data/spec-coverage.tsv with #398, whose moves run 40532346172 proves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the stale rows of
docs/data/spec-coverage.tsv(and the page generated from it) up to what main measures: seven rows leavepartialforcloses,§22 AcDb:Templateleavesmissingforpartial,§9keepscloseswith its evidence and a live tracker, and the "Last measured" line moves to the current main run.Spec reference
ODA v5.4.1 sections §9, §22, §20.4.3, §20.4.4, §20.4.5, §20.4.46, §20.4.60, §20.4.68 and §20.4.75. Refs #127, #133, #140, #147, #148 (all stay open: no row here becomes
complete).Evidence for every state that moves is CI run 40532346172, the newest green
ci.ymlrun onmain(e7c53e1), artifactcorpus-measurement; all its jobs passed,Corpus (public DWG)included.Test plan
python3 tools/ci/spec_coverage.py --write, then--check:spec-coverage: 139 rows, 135 required sections, 0 problems.python3 tools/oracle/spec_notes.py <oracle.log of the run> docs/data/spec-coverage.tsvrun on a copy of the TSV changes nothing: every oracle note already matches the run'soracle.log(52 sections annotated, no cell differs).python3 tools/maintainer/train/arch.py check: clean.corpus-results.json: 52 drawings, 15,541 decoded, 533 skipped, 0 errored, and the per-kinderrorsmap is empty on every drawing. None of TEXT, ATTRIB, ATTDEF, MTEXT, VIEW, DIMSTYLE or HATCH appears among the 28 skipped kinds. Every file ofcorpus-logs/coverage-*.txtreportserr0.State changes (
closeshere means what the page defines: the decoder ends on its exact boundary on every corpus record of the type; no row iscompletebecause R13 has no AutoCAD-written drawing, #345):BLreactor count of the R2007+ entry prefix and they close; #297 had decoded the 20 R14 records; the run has errored 0.errors. The oracle does not score HATCH yet (48 paired records unscored); the row says so.dxf_header::measurementreads$MEASUREMENTfrom it anddwg-to-dxfwrites it (#320). Measured departure recorded in the source: from R2007 the description length counts UTF-16 units where §22 counts bytes.probe_dxf_headerover the 42 drawings with an export: 9,583 variables written, 9,410 agree, 173 hold a stated relation, 0 disagree, 0 extra (dxf-header-probe.log). Not exposed: the description text and the other fields. Not measured: R14 and R2000, whose template is §3.2.4's and is not read.Not moved, on purpose:
closes. It cannot becompletewhile R13 has no file. The note now carries the per-release evidence fromheader-probe.logof the run (8 of 8 drawings close on each of R14, R2000, R2004, R2007, R2010 and R2013, 4 of 4 on R2018, 0 disagree on every one), which is what closed Header variables, R2000 #128, Header variables, R2004 and R2007 #129 and Header variables, R2010 to R2018 #130; its tracking cell moves from the closed A table-driven header decoder with release ranges #126 to Header variables, R13 and R14 #127, which tracks R13. The DXF writer figures in the note are refreshed to the run's (9,583 written, 9,410 agree, 173 by relation, 0 disagree).partial: 4 values still differ from the export (LTYPE dash shape flag: the DWG sets 8 where the export writes 2 #242).Page text: the "Last measured" line now reads 2026-10-27, main e7c53e1, with the run linked, and says the oracle notes match the run's
oracle.logwhile a note's other numbers cite the PR or run that measured them. The paragraph that saidclosescame from a local 19-file corpus re-measured later "by the 0.2.0 measurement work" now says it comes from the Corpus CI job on the 52 public drawings (#225).Not changed, though also behind:
docs/release-1.0-criteria.md(its R3 row quotes 67closesand 31partial, and R8 quotes 308 erroring records; its "Last measured" line is 2026-10-21). A status there changes only in the PR that links the new evidence, so that is a separate change.Source-provenance declaration
By submitting this PR I certify that my contribution does not incorporate executable code from any source whose license is incompatible with Apache-2.0. Specifically:
CLEANROOM.md).dwg-rsis Apache-2.0 and must remain compatible.My contribution is based on:
CLEANROOM.md.See
CLEANROOM.mdfor the full allowed/forbidden source list and the honest scope of what "clean-room" means for this project.Developer Certificate of Origin
By submitting this PR, I certify that the contribution complies with the
Developer Certificate of Origin 1.1.
Specifically, I affirm that the contribution is my own work (or rightfully
licensed to me) and that it can be distributed under the project's Apache-2.0
license.
I will sign off commits with
git commit -swhen asked, which adds aSigned-off-bytrailer to the commit message asserting the DCO.