Repository navigation
docs(criteria): re-measure the 1.0 requirements from the 2026-10-27 main run (#195) - #401
Merged
Merged
Conversation
…d say what measured them (#140, #147, #148, #133, #127) Seven rows leave partial for closes because no record of any kind errors on the 52 drawings of run 40532346172 and the errors their notes still quote were fixed: TEXT, ATTRIB, ATTDEF (#258), MTEXT (#261), VIEW (#263, #284), DIMSTYLE (#293) and HATCH (#264, the R14 records routed). §22 AcDb:Template goes from missing to partial: dxf_header reads $MEASUREMENT from it (#320). §9 stays closes, now tracked by #127 (R13) and carrying the per-release evidence behind closing #128, #129 and #130. The page's Last measured line and the paragraph that said closes came from a local 19-file corpus are updated.
…ain run (#195) Header, R2, R3, R4, R8, X1 and S3 now carry what run 40542129639 (main 61255e9) and docs/data/spec-coverage.tsv say: 52 drawings with 0 errored records and 533 skipped, 53 sections scored by the DXF oracle with 22 values disagreeing, 90 closes, 13 partial, 6 decoder and 29 missing rows, a wasm32 compile of the library in the Clippy job. X1 (DXF) moves from not measured to failed: the HEADER, TABLES, ENTITIES and BLOCKS probes pair the written records with AutoCAD's export and find 0 groups disagreeing, and 342 entity records of 18 kinds and the OBJECTS section are not written. No other status changes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # docs/data/spec-coverage.tsv # docs/spec-coverage.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains #398's commit (
f540e7e, merged into the branch) and must land after #398. Once #398 is onmainits diff drops out of this one.Re-measures the requirements of
docs/release-1.0-criteria.mdthat a green main run can re-measure, and changes only what that run proves. One status flips: X1 (DXF) goes fromnot measuredtofailed. Every other status is unchanged. R-numbering and wording are otherwise intact.Spec reference
None; no code. Refs #195 (the epic; it stays open) and #169, #381.
Evidence: CI run 40542129639, the
ci.ymlrun onmainat61255e9, every job success, artifactcorpus-measurement(corpus-results.json,oracle-summary.md,oracle.tsv,dxf-header-probe.log,dxf-tables-probe.log,dxf-entities-probe.log,dxf-blocks-probe.log,header-probe.log). The R3 counts come fromdocs/data/spec-coverage.tsvat that commit.Test plan
corpus-results.json; scored sections, disagreements and unscored records fromoracle-summary.md; probe totals from the fourdxf-*-probe.logfiles; state counts from the TSV), not copied from earlier prose.python3 tools/ci/spec_coverage.py --check: clean on this branch with docs(spec-coverage): move the rows the 2026-10-27 main run proves, and say what measured them (#140, #147, #148, #133, #127) #398 merged in (this PR adds no change to the page or the TSV beyond docs(spec-coverage): move the rows the 2026-10-27 main run proves, and say what measured them (#140, #147, #148, #133, #127) #398's).What changed, row by row (before, after, evidence):
b268e884"61255e9, run linkedcorpus-results.json: per release 8, 8, 8, 8, 8, 8 and 4 drawings (R14 to R2018)complete; 34missing, 31partial, 6decoder, 67closesmissing, 7partial, 6decoder, 97closesn/achapter 1). Onmainalone it is 29, 13, 6 and 90; #398's seven moves toclosesand §22 topartialare proven by run 40532346172, the run #398 citesoracle-summary.md: 53 spec sections with records; differences BLOCK 3, LTYPE 4, VIEW_CONTROL 6, APPID_CONTROL 4, VPORT 2, MULTILEADER 3. MULTILEADER was scored by #385; its 3 differences are #381.corpus-results.json: errored 0,errorsempty on every drawing, 28 skipped kinds. The status staysfailed: the AppInfo misreading (#137) is still open and the run cannot show otherwise, so that clause is kept.maindxf-*-probe.logfiles. The bar is "equals AutoCAD's own DXF of the same drawing"; the doc definesfailedas measured and not met, andnot measuredas no evidence either way, so the old status no longer fits.wasm32-unknown-unknownin the Clippy job (step "The library builds where usize is 32 bits"), but no job runs tests or a corpus walk on a 32-bit targetRows I did not change, because the run does not move them: R1 (STATUS.md's other numbers are not shown to come from a run), R5 (VISUALSTYLE 1,008 records, 58,104 equal, 264 different, the view styles and MATERIAL still unscored: the run's numbers equal the page's), R6 (42 nextgis and 10 ACadSharp drawings in
pins.tsv, matches), R7, W1 to W3, X2 to X5, S1, S2, S4 and P1 (no evidence in a main run either way). "No recorded fuzz durations" in S3 is kept for the same reason.R3 and #398. The R3 counts include #398 (the spec-coverage refresh): it moves seven rows from
partialtoclosesand §22 frommissingtopartial. This branch has #398's commit merged in (f540e7e, merge commit27bc149), sopython3 tools/ci/spec_coverage.py --checkpasses here (spec-coverage: 139 rows, 135 required sections, 0 problems) and R3 matches the TSV the branch carries. It must land after #398; the other rows are measured from run 40542129639 and do not depend on it.Source-provenance declaration
By submitting this PR I certify that my contribution does not incorporate executable code from any source whose license is incompatible with Apache-2.0. Specifically:
CLEANROOM.md).dwg-rsis Apache-2.0 and must remain compatible.My contribution is based on:
CLEANROOM.md.See
CLEANROOM.mdfor the full allowed/forbidden source list and the honest scope of what "clean-room" means for this project.Developer Certificate of Origin
By submitting this PR, I certify that the contribution complies with the
Developer Certificate of Origin 1.1.
Specifically, I affirm that the contribution is my own work (or rightfully
licensed to me) and that it can be distributed under the project's Apache-2.0
license.
I will sign off commits with
git commit -swhen asked, which adds aSigned-off-bytrailer to the commit message asserting the DCO.