Skip to content

fix(release/packs): 可发包依赖拓扑构建 + 安装占用 DRY - #80

Merged
Tanya7z merged 2 commits into
mainfrom
cursor/bc-049f9a01-bec5-4ef6-bfd1-c0b563fedd36-f051
Jul 26, 2026
Merged

fix(release/packs): 可发包依赖拓扑构建 + 安装占用 DRY#80
Tanya7z merged 2 commits into
mainfrom
cursor/bc-049f9a01-bec5-4ef6-bfd1-c0b563fedd36-f051

Conversation

@cursor

@cursor cursor Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

审查 main@cab68c5(3e1236e 世界包安装决策重构合入后)的 SOLID 债,直接补丁。

BLOCKER/MAJOR

  • MAJOR · DRY/OCP/DIPnpm-publish.yml 应急补发只 build SDK,@sfmc-bds/cli 会因缺 bds-tools dist 在 --dts 挂掉(已本地复现)。现改为 listPublishableBuildDeps + build-publishable.mjs --workspace,依赖闭包权威来自 package.jsonNPM_PUBLISH_PACKAGES
  • MAJOR · DRY/LSP(承接 fix(release): push 缺失态 DRY + build-publishable #79):push 缺失态回退改为 listUnpushedExistingVersionTagschangeset-release 全量构建改为 build-publishable.mjs(拓扑序,不再 YAML 手抄列表)。本 PR 覆盖并增强 fix(release): push 缺失态 DRY + build-publishable #79(拓扑由 deps 派生,非硬编码 sdk/bds-tools 优先)。

本轮 push(world-packs)审查补丁

  • MINOR · DRYscanDestOccupancy 抽取 readPackDirOccupancy(去掉嵌套 BOM 双读)
  • MINOR:删除恒真死不变式 folderName !== same.folderName
  • MINOR · LSPDestOccupancy.kind 保留真实 kind,决策/冲突 UI 不再伪造 incoming.kind
  • 补测:残缺 manifest 同 uuid → 按版本 needConfirm / 静默升级(非旁路新目录)

CI

本轮 push 的 ootb / changeset-release 均已 success;无新 wf 失败需修。

Test plan

  • node --test tools/changeset-release.test.mjs(12 pass)
  • node --test bds-tools/world-packs.test.mjs(14 pass)
  • rm -rf bds-tools/dist sfmc/dist && node tools/build-publishable.mjs --workspace @sfmc-bds/cli(sdk+bds-tools+cli 成功)
  • CI ootb on this PR

Note

建议关闭/不合并草稿 #79(本 PR 已包含其意图并修了 npm-publish 依赖闭包)。

Open in Web View Automation 

- listPublishableBuildDeps/Order 从 package.json∩NPM_PUBLISH_PACKAGES 派生
- npm-publish / changeset-release 共用 build-publishable(不再硬编码只 build SDK)
- push 缺失态对齐 listUnpushedExistingVersionTags(DRY/LSP)
- world-packs:readPackDirOccupancy 抽取;去掉死不变式;occupancy 保留真实 kind

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z
Tanya7z marked this pull request as ready for review July 26, 2026 11:05
@cursor

cursor Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z
Tanya7z merged commit e75f2d6 into main Jul 26, 2026
1 check failed
Tanya7z added a commit that referenced this pull request Jul 26, 2026
…ae77-d60c9fdf6f38-7762

fix(bds-tools): 修复 #80/#81 合并损坏的 scanDestOccupancy(恢复 ootb/发版构建)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants