fix(release/packs): 可发包依赖拓扑构建 + 安装占用 DRY - #80
Merged
Tanya7z merged 2 commits intoJul 26, 2026
Conversation
- listPublishableBuildDeps/Order 从 package.json∩NPM_PUBLISH_PACKAGES 派生 - npm-publish / changeset-release 共用 build-publishable(不再硬编码只 build SDK) - push 缺失态对齐 listUnpushedExistingVersionTags(DRY/LSP) - world-packs:readPackDirOccupancy 抽取;去掉死不变式;occupancy 保留真实 kind Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
This was referenced Jul 25, 2026
Tanya7z
marked this pull request as ready for review
July 26, 2026 11:05
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 26, 2026
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
审查 main@cab68c5(
3e1236e世界包安装决策重构合入后)的 SOLID 债,直接补丁。BLOCKER/MAJOR
npm-publish.yml应急补发只 build SDK,@sfmc-bds/cli会因缺bds-toolsdist 在--dts挂掉(已本地复现)。现改为listPublishableBuildDeps+build-publishable.mjs --workspace,依赖闭包权威来自package.json∩NPM_PUBLISH_PACKAGES。listUnpushedExistingVersionTags;changeset-release全量构建改为build-publishable.mjs(拓扑序,不再 YAML 手抄列表)。本 PR 覆盖并增强 fix(release): push 缺失态 DRY + build-publishable #79(拓扑由 deps 派生,非硬编码 sdk/bds-tools 优先)。本轮 push(world-packs)审查补丁
scanDestOccupancy抽取readPackDirOccupancy(去掉嵌套 BOM 双读)folderName !== same.folderNameDestOccupancy.kind保留真实 kind,决策/冲突 UI 不再伪造incoming.kindCI
本轮 push 的 ootb / changeset-release 均已 success;无新 wf 失败需修。
Test plan
node --test tools/changeset-release.test.mjs(12 pass)node --test bds-tools/world-packs.test.mjs(14 pass)rm -rf bds-tools/dist sfmc/dist && node tools/build-publishable.mjs --workspace @sfmc-bds/cli(sdk+bds-tools+cli 成功)Note
建议关闭/不合并草稿 #79(本 PR 已包含其意图并修了 npm-publish 依赖闭包)。